Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-interactive-rebase-tool 2.3.0 #137013

Merged

Conversation

neersighted
Copy link
Contributor

Created with brew bump-formula-pr.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 19, 2023
@chenrui333
Copy link
Member

  error: unknown lint: `ffi_unwind_calls`
    --> src/runtime/src/lib.rs:17:1
     |
  17 | / #![deny(
  18 | |     absolute_paths_not_starting_with_crate,
  19 | |     deprecated_in_future,
  20 | |     elided_lifetimes_in_paths,
  ...  |
  52 | |     variant_size_differences
  53 | | )]
     | |__^
     |
     = note: the `ffi_unwind_calls` lint is unstable
     = note: see issue #74990 <https://github.com/rust-lang/rust/issues/74990> for more information
  note: the lint level is defined here
    --> src/runtime/src/lib.rs:14:2
     |
  14 |     warnings
     |     ^^^^^^^^
     = note: `#[deny(unknown_lints)]` implied by `#[deny(warnings)]`
  
     Compiling girt-todo-file v2.3.0 (/private/tmp/git-interactive-rebase-tool-20230719-52883-1dfdoy8/git-interactive-rebase-tool-2.3.0/src/todo_file)

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jul 19, 2023
@MitMaro
Copy link
Contributor

MitMaro commented Jul 19, 2023

👋🏼 Maintainer of git-interactive-rebase-tool here!

The above error is caused by using an older stable version of Rust. I'm not sure of the usual process for updated/fixing the rust version in Homebrew, but I believe the latest stable version of Rust should compile/build correctly.

@neersighted
Copy link
Contributor Author

This should be green with Rust 1.71 (#136514)

@MitMaro
Copy link
Contributor

MitMaro commented Jul 21, 2023

@neersighted , you may have some success getting this working with the older version of Rust by "capping" the lints. Inside the def install function, add ENV["RUSTFLAGS"] = "--cap-lints warn" (example).

Since this is only failing due to a linting error and there isn't any reason why an older version should fail, disabling the linting shouldn't be a problem for a build.

@neersighted
Copy link
Contributor Author

That's a fair point, though I was figuring that it would be better to skip a workaround as 1.71 is imminent. I'll go ahead and push it up with a FIXME; WDYT @chenrui333?

@neersighted neersighted force-pushed the bump-git-interactive-rebase-tool-2.3.0 branch from 5d41e91 to 9e6fbf3 Compare July 21, 2023 12:27
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 24, 2023
@github-actions github-actions bot closed this Jul 25, 2023
@neersighted
Copy link
Contributor Author

@chenrui333 Could you please reopen this and give it the right lifecycle label?

@chenrui333 chenrui333 reopened this Jul 26, 2023
@chenrui333 chenrui333 force-pushed the bump-git-interactive-rebase-tool-2.3.0 branch from 9e6fbf3 to c13d089 Compare July 26, 2023 15:37
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed stale No recent activity build failure CI fails while building the software pending-rust-update Blocked by `rust` upgrade PR labels Jul 26, 2023
@chenrui333 chenrui333 force-pushed the bump-git-interactive-rebase-tool-2.3.0 branch from c13d089 to fe5ceb8 Compare July 26, 2023 15:45
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed CI-requeued PR has been re-added to the queue labels Jul 26, 2023
git-interactive-rebase-tool: update build and test

Signed-off-by: Rui Chen <[email protected]>

git-interactive-rebase-tool: needs zlib for linux build

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the bump-git-interactive-rebase-tool-2.3.0 branch from fe5ceb8 to 595a7a1 Compare July 26, 2023 17:57
@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 27, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 27, 2023 01:15
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 27, 2023
Merged via the queue into Homebrew:master with commit 18d4e96 Jul 27, 2023
@neersighted neersighted deleted the bump-git-interactive-rebase-tool-2.3.0 branch July 27, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants