Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust 1.71.0 #136514

Merged
merged 2 commits into from
Jul 26, 2023
Merged

rust 1.71.0 #136514

merged 2 commits into from
Jul 26, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Jul 13, 2023 •
edited by p-linnane
Loading

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing labels Jul 13, 2023
@ZhongRuoyu ZhongRuoyu added the resource updates needed Resource blocks may still have outdated versions label Jul 13, 2023
@ZhongRuoyu

This comment was marked as resolved.

Sign in to view
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 13, 2023
@p-linnane p-linnane removed the resource updates needed Resource blocks may still have outdated versions label Jul 13, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 13, 2023
@SMillerDev
Copy link
Member 

  FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/NativeFormatting.cpp.o 
  /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/build/x86_64-apple-darwin/llvm/build/lib/Support -I/tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/lib/Support -I/tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/build/x86_64-apple-darwin/llvm/build/include -I/tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/include -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include -ffunction-sections -fdata-sections -fPIC --target=x86_64-apple-darwin -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -w -fdiagnostics-color -Werror=global-constructors -O3 -DNDEBUG -std=c++17 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacosx-version-min=12.6  -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/NativeFormatting.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/NativeFormatting.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/NativeFormatting.cpp.o -c /tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/lib/Support/NativeFormatting.cpp
  /tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/lib/Support/NativeFormatting.cpp:172:12: error: expected unqualified-id
    if (std::isnan(N)) {
             ^
  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/math.h:165:5: note: expanded from macro 'isnan'
      ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
      ^
  /tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/lib/Support/NativeFormatting.cpp:175:19: error: expected unqualified-id
    } else if (std::isinf(N)) {
                    ^
  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/math.h:160:5: note: expanded from macro 'isinf'
      ( sizeof(x) == sizeof(float)  ? __inline_isinff((float)(x))          \
      ^
  /tmp/rust-20230713-6371-1825lt2/rustc-1.71.0-src/src/llvm-project/llvm/lib/Support/NativeFormatting.cpp:176:16: error: expected unqualified-id
      S << (std::signbit(N) ? "-INF" : "INF");
                 ^
  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/math.h:170:5: note: expanded from macro 'signbit'
      ( sizeof(x) == sizeof(float)  ? __inline_signbitf((float)(x))        \
      ^

@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label Jul 16, 2023
This was referenced Jul 16, 2023
Merged
Merged
@ZhongRuoyu ZhongRuoyu added in progress Stale bot should stay away and removed stale No recent activity labels Jul 17, 2023
@ZhongRuoyu
Copy link
Member Author

The error on ARM and Linux is different:

==> cargo install --root /opt/homebrew/Cellar/rust/1.71.0 --path . --features curl-sys/force-system-lib-on-osx
error: binary `cargo` already exists in destination
Add --force to overwrite

@ZhongRuoyu
rust 1.71.0
53deffe 
Also:
- avoid mixing CLT and Xcode headers;
- force Cargo resource installation to avoid error.
@ZhongRuoyu ZhongRuoyu added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 19, 2023
@neersighted neersighted mentioned this pull request Jul 19, 2023
Merged
@ZhongRuoyu ZhongRuoyu mentioned this pull request Jul 20, 2023
Closed
6 tasks
This was referenced Jul 21, 2023
Merged
Closed
Merged
Closed
Closed
Closed
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 22, 2023
This was referenced Jul 23, 2023
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@chenrui333
Copy link
Member

chenrui333 commented Jul 23, 2023 •
edited
Loading

current track list

This was referenced Jul 24, 2023
Merged
Merged
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 24, 2023
Merged
@chenrui333
Copy link
Member

let's do the merge, I will followup with regression builds. And #137226 would be helpful for next rust bump.

@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 26, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 26, 2023 15:20
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 26, 2023
Merged via the queue into Homebrew:master with commit 3b124a4 Jul 26, 2023
This was referenced Jul 26, 2023
Merged
Merged
Closed
Merged
@ZhongRuoyu ZhongRuoyu deleted the bump-rust-1.71.0 branch August 3, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZhongRuoyu @SMillerDev @chenrui333 @BrewTestBot @p-linnane