Modify run_clairs to take normal vcf as input and start there #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for making this tool, it is really great!
Summary of change:
Modify run_clairs to take normal vcf as input to skip germline calling of normal sample.
Why I want this feature:
In my research, we often do not have a matched normal pair so we default to using a technical control as "normal" to identify and flag error-prone regions. Therefore, when we call somatic variants on multiple tumor samples, we would like to use the same germline vcf and avoid recalling it for every tumor sample in order to cut down runtime. I've modified the code entry point to add an option to pass in an optional normal vcf:
--normal_vcf_fn
where, when not null, skips normal germline calling.Testing done:
I have attached outputs of
ont_quick_demo.sh
from both branches for comparison.master.log
input_normal_vcf.log
Note:
I know this feature might not promote the best use of ClairS. If my use case is too niche, please feel free to ignore this pull request -- I can build my own docker image.