Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored modals to using TS and simplified code for modals. #160

Closed
wants to merge 29 commits into from

Commits on Sep 20, 2020

  1. Made changes so auth on openapi schema works. (#143)

    * Made changes so auth on openapi schema works.
    
    Now requests that require BE to check token will be sent with
    Bearer JWT from FE as a token.
    
    * Made changes based on review on PR #143
    
    * Okay actual changes reflecting review on PR #143.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    61af12d View commit details
    Browse the repository at this point in the history
  2. SignUp Page small screen fix. (#144)

    * Add autochanged tsconfig.
    
    * Make signup page responsive.
    
    * Drop minWidth on dropdowns to prevent overflow.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    0b2d466 View commit details
    Browse the repository at this point in the history
  3. Public page layout component (#146)

    * Make document body fill viewport.
    
    * Add PublicPageLayout component with story.
    
    * Update pages to use public page layout.
    
    Not even going to think about touching SignUpPage
    
    * Add spacing so content is not squished on mobile.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    d77d94f View commit details
    Browse the repository at this point in the history
  4. Event API integration complete (#145)

    * Got a lot of event api integration done, but not all.
    
    Still event edit page left, probably the trickiest one of them all.
    Other than that not sure if there is anything else that uses event
    services (if there are then we can refactor with the new event api
    functions).
    
    Just set up the user api functions file, have not done any integration
    for user api.
    
    * Added autocompletion component
    
    * Finished with integration for event edit page.
    
    * Added changes to address review of PR #145.
    
    * Removed duplicate config to turn off import/prefer-default-export.
    
    * Just for deploy preview.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    e8cb6f3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9060bfc View commit details
    Browse the repository at this point in the history
  6. Change to new api-url. (#151)

    We should change this to be loaded from an env_var soon.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    ebdbc03 View commit details
    Browse the repository at this point in the history
  7. Abstract away card component. (#154)

    * Add Card component with story.
    
    * Replace card usage throughout codebase. (EventDetails is messed up.)
    
    * Add prop passthrough to Card.
    
    * Fix EventDetails component.
    
    * Add title prop to card.
    
    * Refactor usage of CardHeader.
    
    * Change Card export syntax.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    2259743 View commit details
    Browse the repository at this point in the history
  8. Added email verification to signup workflow, integrated auth api from…

    … backend. (#153)
    
    * Added email verification to signup workflow, integrated auth api from backend.
    
    Now frontend just needs to call createNewUser() from
    src/services/AuthService to start the signup workflow, then finishes it
    off with email verif. being handled in frontend.
    
    * Added try catch for calls to a firebase service in signup's handleSubmit.
    
    * Fixed duplicate imports in SignUpPage.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    0f32248 View commit details
    Browse the repository at this point in the history
  9. Add card with vertical tabs. (#156)

    * Add card with vertical tabs.
    
    * Add border, grid, remove ripple.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    04abeeb View commit details
    Browse the repository at this point in the history
  10. Replace match.params as props with hooks (#155)

    * Install react-router types.
    
    * Migrate EventDetailsPage to useParam hook + typescript.
    
    * Migrate EventSignInForm to useParam hook + typescript.
    
    * Migrate EventRsvpPage to useParam hook + typescript.
    
    * Migrate EventEditPage to useParam hook + typescript.
    
    * Migrate ProfilePages to hooks + useParams hook.
    
    * Add yup typing.
    
    * Add @types to dependencies instead of devDep.
    
    @types should be in dev dep to prevent build size bloat, but somehow
    netlify builds fail when @types are not deps.
    
    * Modify CardProps to take in className.
    
    * Change pages to use new Card component.
    
    * Make className optional for cards.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    69b60c3 View commit details
    Browse the repository at this point in the history
  11. Migrate App + Context to Typescript (#158)

    * Add react-router-dom types.
    
    * Changes App + contexts to ts.
    
    * Add types for react-router-dom.
    
    * Fix prop typing.
    godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    d685d29 View commit details
    Browse the repository at this point in the history
  12. Added create event button, page and form (#162)

    * Tsconfig changes again : (
    
    * Added create event button, page and form.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    7e2f53b View commit details
    Browse the repository at this point in the history
  13. Took out most usages of process.env and replaced with config file. (#161

    )
    
    * Took out most usages of process.env and replaced with config file.
    
    Except for src/ServiceWorker.js and ./cypress/plugins because I don't
    think it's a super good idea to change anything in those.
    
    * Made changes based on review+discussions from PR #161.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    0777f84 View commit details
    Browse the repository at this point in the history
  14. UserContextValues's userRole in App now uses backend api to get user'…

    …s role (#164)
    
    * UserContextValues's userRole in App now uses backend api to get user's role.
    
    It used to get the roles from firebase custom claims.
    
    * Add fixes.
    
    * Remove unused function.
    
    Co-authored-by: gypang <[email protected]>
    thai-truong and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    7dea57e View commit details
    Browse the repository at this point in the history
  15. Create Event now works properly and as intended. (#165)

    * Tsconfig changes again : (
    
    * Fixed merge issue
    
    * Create Event now works properly and as intended.
    
    After creating an event, the browser redirects to the newly created
    event's EventDetails page.
    
    Note that fbURL and canvaURL both have to either be empty or filled
    out with a proper URL string, otherwise a status code 400 will be
    sent from the backend server.
    
    * Added url validation to create event form's schema's fbURL + canvaURL.
    
    * Changed process.env in src/index.js to using config.
    thai-truong authored and godwinpang committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    3877f4f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Add alert for successful sign up. (#170)

    * Put an alert for successful sign up.
    
    * Retrigger GH checks on PR #169.
    thai-truong authored Sep 24, 2020
    Configuration menu
    Copy the full SHA
    807ea7e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Configuration menu
    Copy the full SHA
    a266ddf View commit details
    Browse the repository at this point in the history
  2. Automatic rsvp + sign in buttons for affiliates on event details page (

    …#168)
    
    * Added automatic rsvp + sign in buttons for affiliates.
    
    * Merged master into rsvp_signin_buttons.
    thai-truong authored Sep 25, 2020
    Configuration menu
    Copy the full SHA
    eeeab8a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Configuration menu
    Copy the full SHA
    7574998 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. SignUp Page small screen fix. (#144)

    * Add autochanged tsconfig.
    
    * Make signup page responsive.
    
    * Drop minWidth on dropdowns to prevent overflow.
    
    Rebase commits from modal_refactor onto master
    godwinpang authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    d64fdcd View commit details
    Browse the repository at this point in the history
  2. Event API integration complete (#145)

    * Got a lot of event api integration done, but not all.
    
    Still event edit page left, probably the trickiest one of them all.
    Other than that not sure if there is anything else that uses event
    services (if there are then we can refactor with the new event api
    functions).
    
    Just set up the user api functions file, have not done any integration
    for user api.
    
    * Added autocompletion component
    
    * Finished with integration for event edit page.
    
    * Added changes to address review of PR #145.
    
    * Removed duplicate config to turn off import/prefer-default-export.
    
    * Just for deploy preview.
    
    Rebase modal_factor's commits onto master
    thai-truong authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    c286a92 View commit details
    Browse the repository at this point in the history
  3. Abstract away card component. (#154)

    * Add Card component with story.
    
    * Replace card usage throughout codebase. (EventDetails is messed up.)
    
    * Add prop passthrough to Card.
    
    * Fix EventDetails component.
    
    * Add title prop to card.
    
    * Refactor usage of CardHeader.
    
    * Change Card export syntax.
    
    Rebase the commits from modal_refactor to master for modal_refactor's PR
    godwinpang authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    7ca93cb View commit details
    Browse the repository at this point in the history
  4. Added email verification to signup workflow, integrated auth api from…

    … backend. (#153)
    
    * Added email verification to signup workflow, integrated auth api from backend.
    
    Now frontend just needs to call createNewUser() from
    src/services/AuthService to start the signup workflow, then finishes it
    off with email verif. being handled in frontend.
    
    * Added try catch for calls to a firebase service in signup's handleSubmit.
    
    * Fixed duplicate imports in SignUpPage.
    
    Rebase modal_refactor's 3 commits onto master (in progress)
    thai-truong authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    37399f6 View commit details
    Browse the repository at this point in the history
  5. Replace match.params as props with hooks (#155)

    * Install react-router types.
    
    * Migrate EventDetailsPage to useParam hook + typescript.
    
    * Migrate EventSignInForm to useParam hook + typescript.
    
    * Migrate EventRsvpPage to useParam hook + typescript.
    
    * Migrate EventEditPage to useParam hook + typescript.
    
    * Migrate ProfilePages to hooks + useParams hook.
    
    * Add yup typing.
    
    * Add @types to dependencies instead of devDep.
    
    @types should be in dev dep to prevent build size bloat, but somehow
    netlify builds fail when @types are not deps.
    
    * Modify CardProps to take in className.
    
    * Change pages to use new Card component.
    
    * Make className optional for cards.
    
    Rebase the commits of modal_refactor to master (in progress)
    godwinpang authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    3a66160 View commit details
    Browse the repository at this point in the history
  6. Added create event button, page and form (#162)

    * Tsconfig changes again : (
    
    * Added create event button, page and form.
    
    Rebase modal_refactor's commits onto master branch (in progress)
    thai-truong authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    2723836 View commit details
    Browse the repository at this point in the history
  7. Create Event now works properly and as intended. (#165)

    * Tsconfig changes again : (
    
    * Fixed merge issue
    
    * Create Event now works properly and as intended.
    
    After creating an event, the browser redirects to the newly created
    event's EventDetails page.
    
    Note that fbURL and canvaURL both have to either be empty or filled
    out with a proper URL string, otherwise a status code 400 will be
    sent from the backend server.
    
    * Added url validation to create event form's schema's fbURL + canvaURL.
    
    * Changed process.env in src/index.js to using config.
    thai-truong authored and Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    f350415 View commit details
    Browse the repository at this point in the history
  8. Refactored modals to using TS and simplified code for modals.

    Also added a story for modals to storybook.
    Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    ae8c0d6 View commit details
    Browse the repository at this point in the history
  9. Added ModalWithActionButtons as another level of abstraction to refactor

    This is so that ButtonWithModal is strictly a Button component + a
    Modal component used as a black box (which is ModalWithActionButtons in
    this case). ModalWithActionButtons now handles rendering all the action
    buttons for a BaseModal.
    Thai committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    e046c36 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5378dce View commit details
    Browse the repository at this point in the history