-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored modals to using TS and simplified code for modals. #160
Commits on Sep 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 61af12d - Browse repository at this point
Copy the full SHA 61af12dView commit details -
SignUp Page small screen fix. (#144)
* Add autochanged tsconfig. * Make signup page responsive. * Drop minWidth on dropdowns to prevent overflow.
Configuration menu - View commit details
-
Copy full SHA for 0b2d466 - Browse repository at this point
Copy the full SHA 0b2d466View commit details -
Public page layout component (#146)
* Make document body fill viewport. * Add PublicPageLayout component with story. * Update pages to use public page layout. Not even going to think about touching SignUpPage * Add spacing so content is not squished on mobile.
Configuration menu - View commit details
-
Copy full SHA for d77d94f - Browse repository at this point
Copy the full SHA d77d94fView commit details -
Event API integration complete (#145)
* Got a lot of event api integration done, but not all. Still event edit page left, probably the trickiest one of them all. Other than that not sure if there is anything else that uses event services (if there are then we can refactor with the new event api functions). Just set up the user api functions file, have not done any integration for user api. * Added autocompletion component * Finished with integration for event edit page. * Added changes to address review of PR #145. * Removed duplicate config to turn off import/prefer-default-export. * Just for deploy preview.
Configuration menu - View commit details
-
Copy full SHA for e8cb6f3 - Browse repository at this point
Copy the full SHA e8cb6f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9060bfc - Browse repository at this point
Copy the full SHA 9060bfcView commit details -
We should change this to be loaded from an env_var soon.
Configuration menu - View commit details
-
Copy full SHA for ebdbc03 - Browse repository at this point
Copy the full SHA ebdbc03View commit details -
Abstract away card component. (#154)
* Add Card component with story. * Replace card usage throughout codebase. (EventDetails is messed up.) * Add prop passthrough to Card. * Fix EventDetails component. * Add title prop to card. * Refactor usage of CardHeader. * Change Card export syntax.
Configuration menu - View commit details
-
Copy full SHA for 2259743 - Browse repository at this point
Copy the full SHA 2259743View commit details -
Added email verification to signup workflow, integrated auth api from…
… backend. (#153) * Added email verification to signup workflow, integrated auth api from backend. Now frontend just needs to call createNewUser() from src/services/AuthService to start the signup workflow, then finishes it off with email verif. being handled in frontend. * Added try catch for calls to a firebase service in signup's handleSubmit. * Fixed duplicate imports in SignUpPage.
Configuration menu - View commit details
-
Copy full SHA for 0f32248 - Browse repository at this point
Copy the full SHA 0f32248View commit details -
Add card with vertical tabs. (#156)
* Add card with vertical tabs. * Add border, grid, remove ripple.
Configuration menu - View commit details
-
Copy full SHA for 04abeeb - Browse repository at this point
Copy the full SHA 04abeebView commit details -
Replace match.params as props with hooks (#155)
* Install react-router types. * Migrate EventDetailsPage to useParam hook + typescript. * Migrate EventSignInForm to useParam hook + typescript. * Migrate EventRsvpPage to useParam hook + typescript. * Migrate EventEditPage to useParam hook + typescript. * Migrate ProfilePages to hooks + useParams hook. * Add yup typing. * Add @types to dependencies instead of devDep. @types should be in dev dep to prevent build size bloat, but somehow netlify builds fail when @types are not deps. * Modify CardProps to take in className. * Change pages to use new Card component. * Make className optional for cards.
Configuration menu - View commit details
-
Copy full SHA for 69b60c3 - Browse repository at this point
Copy the full SHA 69b60c3View commit details -
Migrate App + Context to Typescript (#158)
* Add react-router-dom types. * Changes App + contexts to ts. * Add types for react-router-dom. * Fix prop typing.
Configuration menu - View commit details
-
Copy full SHA for d685d29 - Browse repository at this point
Copy the full SHA d685d29View commit details -
Added create event button, page and form (#162)
* Tsconfig changes again : ( * Added create event button, page and form.
Configuration menu - View commit details
-
Copy full SHA for 7e2f53b - Browse repository at this point
Copy the full SHA 7e2f53bView commit details -
Took out most usages of process.env and replaced with config file. (#161
) * Took out most usages of process.env and replaced with config file. Except for src/ServiceWorker.js and ./cypress/plugins because I don't think it's a super good idea to change anything in those. * Made changes based on review+discussions from PR #161.
Configuration menu - View commit details
-
Copy full SHA for 0777f84 - Browse repository at this point
Copy the full SHA 0777f84View commit details -
UserContextValues's userRole in App now uses backend api to get user'…
…s role (#164) * UserContextValues's userRole in App now uses backend api to get user's role. It used to get the roles from firebase custom claims. * Add fixes. * Remove unused function. Co-authored-by: gypang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7dea57e - Browse repository at this point
Copy the full SHA 7dea57eView commit details -
Create Event now works properly and as intended. (#165)
* Tsconfig changes again : ( * Fixed merge issue * Create Event now works properly and as intended. After creating an event, the browser redirects to the newly created event's EventDetails page. Note that fbURL and canvaURL both have to either be empty or filled out with a proper URL string, otherwise a status code 400 will be sent from the backend server. * Added url validation to create event form's schema's fbURL + canvaURL. * Changed process.env in src/index.js to using config.
Configuration menu - View commit details
-
Copy full SHA for 3877f4f - Browse repository at this point
Copy the full SHA 3877f4fView commit details
Commits on Sep 24, 2020
-
Add alert for successful sign up. (#170)
* Put an alert for successful sign up. * Retrigger GH checks on PR #169.
Configuration menu - View commit details
-
Copy full SHA for 807ea7e - Browse repository at this point
Copy the full SHA 807ea7eView commit details
Commits on Sep 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a266ddf - Browse repository at this point
Copy the full SHA a266ddfView commit details -
Automatic rsvp + sign in buttons for affiliates on event details page (…
…#168) * Added automatic rsvp + sign in buttons for affiliates. * Merged master into rsvp_signin_buttons.
Configuration menu - View commit details
-
Copy full SHA for eeeab8a - Browse repository at this point
Copy the full SHA eeeab8aView commit details
Commits on Sep 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7574998 - Browse repository at this point
Copy the full SHA 7574998View commit details
Commits on Oct 3, 2020
-
SignUp Page small screen fix. (#144)
* Add autochanged tsconfig. * Make signup page responsive. * Drop minWidth on dropdowns to prevent overflow. Rebase commits from modal_refactor onto master
Configuration menu - View commit details
-
Copy full SHA for d64fdcd - Browse repository at this point
Copy the full SHA d64fdcdView commit details -
Event API integration complete (#145)
* Got a lot of event api integration done, but not all. Still event edit page left, probably the trickiest one of them all. Other than that not sure if there is anything else that uses event services (if there are then we can refactor with the new event api functions). Just set up the user api functions file, have not done any integration for user api. * Added autocompletion component * Finished with integration for event edit page. * Added changes to address review of PR #145. * Removed duplicate config to turn off import/prefer-default-export. * Just for deploy preview. Rebase modal_factor's commits onto master
Configuration menu - View commit details
-
Copy full SHA for c286a92 - Browse repository at this point
Copy the full SHA c286a92View commit details -
Abstract away card component. (#154)
* Add Card component with story. * Replace card usage throughout codebase. (EventDetails is messed up.) * Add prop passthrough to Card. * Fix EventDetails component. * Add title prop to card. * Refactor usage of CardHeader. * Change Card export syntax. Rebase the commits from modal_refactor to master for modal_refactor's PR
Configuration menu - View commit details
-
Copy full SHA for 7ca93cb - Browse repository at this point
Copy the full SHA 7ca93cbView commit details -
Added email verification to signup workflow, integrated auth api from…
… backend. (#153) * Added email verification to signup workflow, integrated auth api from backend. Now frontend just needs to call createNewUser() from src/services/AuthService to start the signup workflow, then finishes it off with email verif. being handled in frontend. * Added try catch for calls to a firebase service in signup's handleSubmit. * Fixed duplicate imports in SignUpPage. Rebase modal_refactor's 3 commits onto master (in progress)
Configuration menu - View commit details
-
Copy full SHA for 37399f6 - Browse repository at this point
Copy the full SHA 37399f6View commit details -
Replace match.params as props with hooks (#155)
* Install react-router types. * Migrate EventDetailsPage to useParam hook + typescript. * Migrate EventSignInForm to useParam hook + typescript. * Migrate EventRsvpPage to useParam hook + typescript. * Migrate EventEditPage to useParam hook + typescript. * Migrate ProfilePages to hooks + useParams hook. * Add yup typing. * Add @types to dependencies instead of devDep. @types should be in dev dep to prevent build size bloat, but somehow netlify builds fail when @types are not deps. * Modify CardProps to take in className. * Change pages to use new Card component. * Make className optional for cards. Rebase the commits of modal_refactor to master (in progress)
Configuration menu - View commit details
-
Copy full SHA for 3a66160 - Browse repository at this point
Copy the full SHA 3a66160View commit details -
Added create event button, page and form (#162)
* Tsconfig changes again : ( * Added create event button, page and form. Rebase modal_refactor's commits onto master branch (in progress)
Configuration menu - View commit details
-
Copy full SHA for 2723836 - Browse repository at this point
Copy the full SHA 2723836View commit details -
Create Event now works properly and as intended. (#165)
* Tsconfig changes again : ( * Fixed merge issue * Create Event now works properly and as intended. After creating an event, the browser redirects to the newly created event's EventDetails page. Note that fbURL and canvaURL both have to either be empty or filled out with a proper URL string, otherwise a status code 400 will be sent from the backend server. * Added url validation to create event form's schema's fbURL + canvaURL. * Changed process.env in src/index.js to using config.
Configuration menu - View commit details
-
Copy full SHA for f350415 - Browse repository at this point
Copy the full SHA f350415View commit details -
Refactored modals to using TS and simplified code for modals.
Also added a story for modals to storybook.
Thai committedOct 3, 2020 Configuration menu - View commit details
-
Copy full SHA for ae8c0d6 - Browse repository at this point
Copy the full SHA ae8c0d6View commit details -
Added ModalWithActionButtons as another level of abstraction to refactor
This is so that ButtonWithModal is strictly a Button component + a Modal component used as a black box (which is ModalWithActionButtons in this case). ModalWithActionButtons now handles rendering all the action buttons for a BaseModal.
Thai committedOct 3, 2020 Configuration menu - View commit details
-
Copy full SHA for e046c36 - Browse repository at this point
Copy the full SHA e046c36View commit details -
Made changes reflecting the review given for PR #160
Thai committedOct 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 5378dce - Browse repository at this point
Copy the full SHA 5378dceView commit details