Took out most usages of process.env and replaced with config file. #161
Conversation
Except for src/ServiceWorker.js and ./cypress/plugins because I don't think it's a super good idea to change anything in those.
|
Deploy preview for hknucsd-portal-dev ready! Built with commit da132b2 |
| @@ -0,0 +1,23 @@ | |||
| type Config = { | |||
| apiKey?: string; | |||
| authDomain?: string; | |||
There was a problem hiding this comment.
i dont have it in my local .env and it's still fine
There was a problem hiding this comment.
idk just part of the firebase config
src/config.ts
Outdated
| storageBucket?: string; | ||
| messagingSenderID?: string; | ||
| appID?: string; | ||
| apiBaseURL?: string; |
There was a problem hiding this comment.
Maybe I should just remove this completely in some other pr, as discussed in some other comment below?
There was a problem hiding this comment.
we still need it for the ApiConfig store
There was a problem hiding this comment.
oh wait nvm yeah
src/index.tsx
Outdated
| authDomain: config.authDomain, | ||
| databaseURL: config.databaseURL, | ||
| projectId: config.projectID, | ||
| storageBuck: config.storageBucket, |
There was a problem hiding this comment.
what happened to my storageBucket :(
src/services/auth.js
Outdated
|
|
||
| const SIGN_UP_URL = `${process.env.REACT_APP_API_BASE_URL}${SIGNUP_ENDPOINT}`; | ||
| const SIGN_UP_URL = `${config.apiBaseURL}${SIGNUP_ENDPOINT}`; |
There was a problem hiding this comment.
is this even used? we should change this to the autogen stuff (can be for later pr)
There was a problem hiding this comment.
Yeah since we have autogen this is not needed anymore, including the function that actually uses this url. Will remove in some other pr
tsconfig.json
Outdated
| "src" | ||
| ], | ||
| "extends": "./tsconfig.paths.json" | ||
| } |
There was a problem hiding this comment.
dude idek anymore newline kinda jank doe
) * Took out most usages of process.env and replaced with config file. Except for src/ServiceWorker.js and ./cypress/plugins because I don't think it's a super good idea to change anything in those. * Made changes based on review+discussions from PR #161.
Except for src/ServiceWorker.js and ./cypress/plugins because I don't
think it's a super good idea to change anything in those.