Migrate App + Context to Typescript #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hknucsd-portal-dev ready! Built with commit c58194d |
godwinpang
changed the title
thai-truong
previously approved these changes
Sep 9, 2020
godwinpang
force-pushed
the
app_context_ts
branch
from
2fd8214
to
a90a212
Compare
thai-truong
approved these changes
Sep 10, 2020
godwinpang
added a commit
that referenced
this pull request
Sep 20, 2020
* Add react-router-dom types. * Changes App + contexts to ts. * Add types for react-router-dom. * Fix prop typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I was gonna fix a bug but ended up just migrating to ts instead :)