Skip to content

Issues: HERA-Team/uvtools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49 Open 20 Closed
49 Open 20 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

labeled_waterfall modifies data in place
#180 opened Dec 6, 2024 by zacharymartinot
Remove existing filtering code and import hera_filters instead
#179 opened Dec 5, 2024 by tyler-a-cox
Fix readme badges
#148 opened Jun 16, 2022 by bhazelton
Upgrade plot.labeled_waterfall
#147 opened Jun 8, 2022 by r-pascua
@r-pascua
Allow an option to use DPSS to filter the time and frequency axes simultaneously
#142 opened Mar 29, 2022 by tyler-a-cox
Remove hera_sim dependence
#137 opened Sep 17, 2021 by aewallwi
Have lin-leastsq use solutions from adjacent times, frequencies, and redundant group elements to speed up convergence.
#133 opened Jun 18, 2021 by aewallwi
Move skip_contiguous_flags, max_contiguous_flags, skip_if_flag_within_wedge_distance from hera_cal.vis_clean.fourier_filter into uvtools.dspec.fourier_filter
#129 opened May 12, 2021 by aewallwi
Make these their own tests.
#127 opened May 3, 2021 by aewallwi
Make these their own tests.
#126 opened May 3, 2021 by aewallwi
Rather than do a loop that tests many choices of window function, this should be parametrized. It should also be broken up into multiple test functions--one that tests basic parameters (e.g. window length, type, and range), and one that tests normalization. There's certainly a way to parametrize fixtures so that you don't need to repeat code when parametrizing over windows, though I don't remember how to do it off the top of my head. Here's a quick example of one such rewrite:
#125 opened May 3, 2021 by aewallwi
These should be separate tests, e.g. test_calc_width_single_filter_size and test_calc_width_bandpass (or something to that effect).
#124 opened May 3, 2021 by aewallwi
Too many assertions.
#123 opened May 3, 2021 by aewallwi
Make these their own tests. I like to make error tests very specific, so it's obvious when things in the code have been changed. For example, suppose the function func raises a ValueError with error message msg when ran with parameters args. I would then write a test along the lines of
#122 opened May 3, 2021 by aewallwi
Too many assertions for a single test.
#121 opened May 3, 2021 by aewallwi
This can be greatly simplified by use of parametrization. I'd also *strongly* recommend against running more than one assert statement per test.
#120 opened May 3, 2021 by aewallwi
Since these parameters are reused, it would make sense to make them fixtures (or global variables, but that's not as neat). As an example, you would do something like
#119 opened May 3, 2021 by aewallwi
Again with multiple assertions per test. A test should only have a single point of failure, otherwise it isn't very helpful when it comes to debugging.
#118 opened May 3, 2021 by aewallwi
Plot horizon in fourier_transform_waterfalls
#109 opened Jan 15, 2021 by r-pascua
@r-pascua
Improve plot.labeled_waterfall
#108 opened Jan 8, 2021 by r-pascua
@r-pascua
CLEAN with multiple disjoint regions does not work.
#104 opened Sep 30, 2020 by aewallwi
subtract weights times resid to compute dayenu model in fourier filter
#101 opened Aug 8, 2020 by aewallwi
More flexible 2d clean areas
#99 opened Aug 6, 2020 by aewallwi
1
Style enforcement
#98 opened Aug 6, 2020 by aewallwi
add rect 2d filtering mode to _fit_basis_2d
#95 opened Aug 5, 2020 by aewallwi
1
ProTip! Updated in the last three days: updated:>2024-12-25.