Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since these parameters are reused, it would make sense to make them fixtures (or global variables, but that's not as neat). As an example, you would do something like #119

Open
aewallwi opened this issue May 3, 2021 · 0 comments

Comments

@aewallwi
Copy link
Collaborator

aewallwi commented May 3, 2021

Since these parameters are reused, it would make sense to make them fixtures (or global variables, but that's not as neat). As an example, you would do something like

@pytest.fixture
def NCHAN():
    return 128

@pytest.fixture
def NTIMES():
    return 10

@pytest.fixture
def TOL():
    return 1e-6

def test_delay_filter_2D(NCHAN, NTIMES, TOL):
    ...

Though I don't like the aesthetics of using fixtures with all capital letters (I prefer to write them as I would a local variable, in all lowercase, with underscores where appropriate).

Originally posted by @r-pascua in #112 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant