Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rect 2d filtering mode to _fit_basis_2d #95

Open
aewallwi opened this issue Aug 5, 2020 · 0 comments · May be fixed by #96
Open

add rect 2d filtering mode to _fit_basis_2d #95

aewallwi opened this issue Aug 5, 2020 · 0 comments · May be fixed by #96

Comments

@aewallwi
Copy link
Collaborator

aewallwi commented Aug 5, 2020

2d clean in _clean_filter rect mode uses pairs of time / frequency fourier regions to define areas to filter. _fit_basis_2d only supports taking the outer product of all time and frequency windows to define cleaning area. Add a rect filter mode that allows for doing rectangular filters with the same notation ad clean.

@aewallwi aewallwi linked a pull request Aug 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant