Payments Filter not working

[dadiorchen]

Refer to Greenstand/treetracker-admin-api#629

[nmcharlton]

@dadiorchen @Tarek-Bohdima Can this be closed? It appears to be working in production.

[Tarek-Bohdima]

@nmcharlton the payment filter problem in #629 was closed as duplicate and kept here, but it is not resolved yet as i tested it now.
Problem : in Payments :
Steps to reproduce:

• Click on Filter
• Organization : choose any one
• Apply -> keep loading and nothing shows
• Click on Filter again
• Reset -> Nothing happens
• Refresh page is the only solution

[nmcharlton]

Thanks @Tarek-Bohdima

It looks like pressing Apply or Reset in the filter adds unsupported parameters to the API query (GET https://test-k8s.treetracker.org/earnings/earnings), triggering a 422 error (Unprocessable Entity):

offset: 0
sort_by: calculated_at
order: desc
limit: 20
earnings_status: all
organization_id: 80                                     <-- Not allowed by API
grower:                                                 <-- Can't be empty, should be omitted
payment_status: all                                     <-- Not allowed by API
phone:                                                  <-- Can't be empty, should be omitted
sub_organization: df12ea71-65e6-4059-b4f5-60c675764497

We should also handle the error more gracefully so the user isn't left waiting for something to happen (see #718 for a similar bug in the Earnings tool).

[tranquanghuy0801]

@nmcharlton if organization_id field is not allow by API, does that mean we should remove that field in Payment Filters?

[nmcharlton]

@nmcharlton if organization_id field is not allow by API, does that mean we should remove that field in Payment Filters?

Yes. The API instead uses sub_organization to filter by org.

[thawansilva]

Hello, I am Thawan, I would like to work on this issue!