Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earnings: Filter by specific organization then all organizations breaks loading #718

Closed
nmcharlton opened this issue Jul 2, 2022 · 2 comments · Fixed by #735
Closed
Assignees
Labels
good first issue Good for newcomers size: small Simple change tool: Earnings Relates to the Earnings tool (formerly Payments) type: bug Something isn't working

Comments

@nmcharlton
Copy link
Collaborator

Steps to reproduce:

  1. Open Earnings tool
  2. Open Filter
  3. Select any value for Organization and press Apply
  4. Open Filter again
  5. Select All for Organization and press Apply
  6. Results don't load

There are two problems here that need fixing:

  1. We are passing an invalid value for sub_organization in the query. Instead, that parameter should be omitted.
  2. We do not correctly handle the error and so leave the loading indicator spinning.
Screen.Recording.2022-07-02.at.12.55.07.mov
@nmcharlton nmcharlton added type: bug Something isn't working good first issue Good for newcomers size: small Simple change tool: Earnings Relates to the Earnings tool (formerly Payments) labels Jul 2, 2022
@kasmediautamu
Copy link
Contributor

@nmcharlton , may I work on this issue if it's available?

@nmcharlton
Copy link
Collaborator Author

nmcharlton commented Jul 4, 2022

Thanks! I've added you to the #admin_panel_chat channel in Slack to get the development credentials for the Admin Panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size: small Simple change tool: Earnings Relates to the Earnings tool (formerly Payments) type: bug Something isn't working
Projects
No open projects
2 participants