feat(earnings): filter by specific organisation, all organizations br… #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmcharlton
approved these changes
Jul 10, 2022
nmcharlton
force-pushed
the
feature/earnings_filter_by_organization
branch
from
2f39caa to
cdfcca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the organization_id and sub_organization filter params from filtersToSubmit
filtering will be successful for the 'ALL' filter combined with all other filters i.e"Grower number", "Grower name"
Issue(s) addressed
loading indicator nolonger hangs for 'ALL' filter
The error will be correctly handled
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements