Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: Remove async-profiler "buildids" support #558

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Jongy
Copy link
Contributor

@Jongy Jongy commented Oct 25, 2022

This was not maintained and the current code is incorrect. When we get to implement the backend part - we can revive this on the agent side.

See my comment here. We're returning a char * where actually a NativeFunc is expected. I don't want to fix the code now because this feature is not used anyway.

That's the range-diff for the async-profiler change:

 1:  f03014d =  1:  f03014d Replace semicolon in method descriptors to vertical bar, since a semicolon is already used to separate between methods
 2:  56daea2 =  2:  56daea2 Remove the "Profiling started" message
 3:  e406f18 =  3:  e406f18 Remove the "Profiling stopped" message
 4:  7a4312d =  4:  7a4312d Compile statically with libstdc++
 5:  52692de =  5:  52692de Build jattach statically
 6:  0edb237 <  -:  ------- Enocde buildid+offset of unknown symbols in the frame (#1)
 7:  0c51507 =  6:  e6abbed Build fdtransfer statically
 8:  114a86f =  7:  4699370 Compile statically with libgcc
 9:  dbc8e7e =  8:  1bef4f5 Force link with memcpy@GLIBC_2.2.5 on x86_64
10:  86595ea =  9:  4018ebb Fix -static-* args passed only in non-MERGE case :(
11:  6f38e45 = 10:  ee5acc1 Close standard streams after forking in fdtransfer
12:  ef1d3b3 = 11:  1eed7a1 Generate randomized fdtransfer path per async-profiler invocation (#635)
13:  48fba55 = 12:  dcfe236 -static-libstdc++ only on musl
14:  008a8cf = 13:  7b51a01 Do not use ELF NODELETE flag because of glibc bug

This was not maintained and the current code is incorrect.
When we get to implement the backend part - we can revive this on the agent side.
@Jongy Jongy merged commit b38f0be into master Oct 25, 2022
@Jongy Jongy deleted the java-remove-ap-buildids branch October 25, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants