Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect buildids&offsets to symbolicate in the backend #559

Open
Jongy opened this issue Oct 25, 2022 · 0 comments
Open

Collect buildids&offsets to symbolicate in the backend #559

Jongy opened this issue Oct 25, 2022 · 0 comments
Labels
runtime/java

Comments

@Jongy
Copy link
Contributor

Jongy commented Oct 25, 2022

We had this feature in the Java profiler & async-profiler, I removed it in #558 because it was not maintained and got broken.
Nowadays we have the application metadata (which already collects buildids for the main library, e.g libjvm.so) so we can make use of that and just add back collection of the offset when we want it again.

Tagged as a Java ticket but it's actually relevant for all.
Jongy added a commit that referenced this issue Oct 25, 2022
@Jongy
java: Remove async-profiler "buildids" support (#558)
b38f0be 
This was not maintained and the current code is incorrect.
When we get to implement the backend part - we can revive this on the agent side.

Created issue #559 to re-implement it in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
runtime/java
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jongy