New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert frame name format to 'function (DSO)' for LIB style. #2

Merged

Jongy merged 10 commits into Granulate:async-profiler-granulate from marcin-ol:apply-common-format-for-DSO-names

Oct 26, 2022

marcin-ol commented Sep 26, 2022 •

edited

Loading

Change formatting of DSO names when LIB reporting is enabled. Results in stack traces resembling the following:

'java;HelloWorld.main([Ljava/lang/String;)V_[j];java/io/File.list()[Ljava/lang/String|_[j];java/io/UnixFileSystem.list(Ljava/io/File|)[Ljava/lang/String|_[j];Java_java_io_UnixFileSystem_list (/opt/java/libjava.so);JNU_NewStringPlatform (/opt/java/libjava.so);jni_NewObject (/opt/java/libjvm.so)': 30,
'java;HelloWorld.main([Ljava/lang/String;)V_[j];java/io/File.list()[Ljava/lang/String|_[j];java/io/UnixFileSystem.list(Ljava/io/File|)[Ljava/lang/String|_[j];[unknown];/lib/x86_64-linux-gnu/libc-2.28.so': 29,

marcin-ol added a commit to marcin-ol/async-profiler that referenced this pull request


          Address comments in review Granulate#2

c1ef61b

- apply common frame format 'function (DSO)',
- return to reporting DSO absolute path

Jongy mentioned this pull request

Introduce and test reporting DSO names in perf and java-ap stack profiles. Granulate/gprofiler#491

Merged

3 tasks

Jongy approved these changes

View reviewed changes

Jongy left a comment

Changes LGTM, I'll see how it looks in the gProfiler side before we merge it.

Jongy reviewed

View reviewed changes

src/frameName.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/stringUtils.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/profiler.cpp Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/frameName.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/frameName.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/frameName.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/frameName.cpp Outdated Show resolved Hide resolved

Jongy approved these changes

View reviewed changes

Jongy left a comment

LGTM. I gave 2 last comments that we can decide we don't do, but please take a look at them

marcin-ol changed the title ~~Convert frame name format to function[DSO] for LIB style.~~ Convert frame name format to 'function (DSO)' for LIB style.

Jongy reviewed

View reviewed changes

src/codeCache.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/codeCache.cpp Outdated Show resolved Hide resolved

Jongy reviewed

View reviewed changes

src/codeCache.cpp Outdated Show resolved Hide resolved

Jongy requested changes

View reviewed changes

Jongy left a comment

Finished reviewing again - see my bigcomment, maybe we should revert it and instead implement in gprofiler

Jongy mentioned this pull request

java: Remove async-profiler "buildids" support Granulate/gprofiler#558

Merged

Jongy force-pushed the async-profiler-granulate branch from 008a8cf to 7b51a01 Compare

October 26, 2022 10:13

marcin-ol added 10 commits

October 26, 2022 12:30


          Convert frame name format to function[DSO] for LIB style.

3347c07


          Address comments in review

00820a8


          Address comments in review Granulate#2

c6251af

- apply common frame format 'function (DSO)',
- return to reporting DSO absolute path


          Handle case of standalone DSO name in stack frames

b8cf235


          Address comments in review, 3

e2b1dfb


          Fix issue with initialization of ap on OpenJ9

66e8e16


          Address comments in review, 4

def11e7


          Remove premature optimization

16e14a6


          Implement missing symbol logic in address lookup function

dff6f7c


          Report library DSO symbol for unmatched addresses

42d967c

marcin-ol force-pushed the apply-common-format-for-DSO-names branch from a3b4174 to 42d967c Compare

October 26, 2022 10:48

Jongy approved these changes

View reviewed changes

Jongy commented Oct 26, 2022

I did some testing. Looks good, and the changes are minimal. Some we could maybe move to the main gProfiler repo, but that's good enough.

Jongy merged commit da08aab into Granulate:async-profiler-granulate

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

aa4669c

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

59b0ba4

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

bb1f846

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

f4d874c

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

97a6767

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

99e87c8

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

de8576d

For Granulate/gprofiler#491

Jongy pushed a commit that referenced this pull request


          Convert frame name format to 'function (DSO)' for LIB style (#2)

a174a70

For Granulate/gprofiler#491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet