feat(helm): remove need for Helm deployer's artifactOverrides #6949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
MarlonGamez
and removed request for
a team
This was referenced Dec 9, 2021
This comment was marked as spam.
This comment was marked as spam.
|
I can take a look at this! |
Codecov Report
@@ Coverage Diff @@
## v2-v1.35.0 #6949 +/- ##
=============================================
Coverage ? 68.05%
=============================================
Files ? 543
Lines ? 25537
Branches ? 0
=============================================
Hits ? 17378
Misses ? 6939
Partials ? 1220 Continue to review full report at Codecov.
|
This was referenced Jan 20, 2022
tejal29
approved these changes
Jan 20, 2022
Closed
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking bug: #6706
Note: This PR is against v2-v1.35.0
It cherry-picks #6913 that was already committed to the main branch.
Description
This PR removes the Helm deployer's
artifactOverridesconfiguration by using Skaffold as the Helm post-renderer to perform our manifest transformations, including image replacement. This simplifies configuring Helm projects and also avoiding resource churn (e.g., setting a label on a deployments will re-create its pods; #3133).This change requires moving our minimum supported Helm version to 3.1.0. This change will break any users that use their own post-renderer hooks via
deploy.helm.flags.TBD:
User facing changes (remove if N/A)