Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] TestFixStdout failing on v2 branch #7033

Closed
tejal29 opened this issue Jan 20, 2022 · 3 comments
Closed

[V2] TestFixStdout failing on v2 branch #7033

tejal29 opened this issue Jan 20, 2022 · 3 comments
Assignees
@MarlonGamez
Labels
2.0.0 Issues related to the 2.0.0 release kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Milestone
2.0.0-alpha1

Comments

@tejal29
Copy link
Contributor

tejal29 commented Jan 20, 2022 •
edited
Loading

As per test logs for PR #6949

Log: https://gist.github.com/tejal29/d147b48ead35f859b382110cd590e291#file-gistfile1-txt-L358

Tests failing:

  1. TestFixOutputFile
  2. TestFixStdout

Steps to reproduce.

  1. Check out GoogleContainerTools:v2-v1.35.0 : https://github.com/GoogleContainerTools/skaffold/tree/v2-v1.35.0
  2. Run integration test.
@tejal29 tejal29 added priority/p1 High impact feature/bug. kind/todo implementation task/epic for the skaffold team 2.0.0 Issues related to the 2.0.0 release labels Jan 20, 2022
@tejal29 tejal29 added this to the 2.0.0-alpha milestone Jan 20, 2022
@tejal29
Copy link
Contributor Author

tejal29 commented Apr 11, 2022 •
edited
Loading

This test is still failing.

Lets add a test.Skip for now and keep this issue open.

Assigning it to @MarlonGamez to add a test.Skip().
Please un-assign after

@tejal29
Copy link
Contributor Author

tejal29 commented Apr 11, 2022

Actually this is part of Making skaffold fix work on v2 which is already assigned to @MarlonGamez

@MarlonGamez
Copy link
Contributor

Closing this in favor of #6721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarlonGamez MarlonGamez

Labels
2.0.0 Issues related to the 2.0.0 release kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Projects
None yet
Milestone
2.0.0-alpha1
Development

No branches or pull requests
2 participants
@tejal29 @MarlonGamez