Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Helm users using artifactOverrides #6952

Closed
briandealwis opened this issue Dec 9, 2021 · 0 comments · Fixed by #7707
Closed

Migrate Helm users using artifactOverrides #6952

briandealwis opened this issue Dec 9, 2021 · 0 comments · Fixed by #7707
Assignees
Labels
area/deploy area/render deploy/helm kind/todo implementation task/epic for the skaffold team
Milestone

Comments

@briandealwis
Copy link
Member

Tracking bug: #6706

#6949 removes the artifactOverrides field and instead configured Helm to use Skaffold as a post-renderer filter for hydrating the Helm-rendered manifests. One requirement for this to work is that the images in the rendered manifests must correspond to either the build.artifacts[].image or to the final locations of the images (post-default-repo). This may be a breaking change as some users may have been using image defaults that don't correspond to the image names in the build.artifacts[].image and so their deployments may cease to work.

We should convert uses of artifactOverrides into setValues where we populate the keys with the corresponding artifact[].image using the configured Helm strategy.


An alternative strategy would be to check for this situation in the schema-upgrade. We could invoke helm template and then look for matched and unmatched image names. If we found mismatches, Skaffold could warn the user or abort the upgrade and direct them to do a manual upgrade. Warning seems inadequate as a missed image can result in a broken deployment (either referencing an image that does not exist or that is not the built image), and users may miss the warning. Aborting and requiring an update would entail one-off toil for users, since they would need to examine their charts and skaffold.yaml to see if there is a discrepancy. Since some users won't rewrite their skaffold.yaml — since we silently upgrade from previous schema versions — our upgrade process would also invoke helm template each time, which is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy area/render deploy/helm kind/todo implementation task/epic for the skaffold team
Projects
None yet
2 participants