WIP: Feature/healthcheck signal

[chrisz100]

Solves #17

[dlorenc]

From the build error, it looks like you'll have to translate from the dockerfile HealthCheck type to the go-containerregistry one.

[chrisz100]

exactly. Just looking into how to do this the most efficiently.

Just creating a v1.HealthConfig and passing all values would work, but I wouldn't really regard this as future proof or clean tbh. Any alternatives you could think of?

[chrisz100]

So... I don't really like this way of doing it but it works and there is no way to convert struct to struct more fail-safe/ autonomous that I am aware of.

[dlorenc]

So... I don't really like this way of doing it but it works and there is no way to convert struct to struct more fail-safe/ autonomous that I am aware of.

Hmm, if the structs are actually equivalent you might be able to cast them: https://beta.golang.org/doc/go1.8#language

That would then error if the types don't match which would probably be a good thing.

[chrisz100]

This is the case as of now as well sadly:
config.Healthcheck = v1.HealthConfig(h.cmd.Health)

pkg/commands/healthcheck.go:44:38: cannot convert h.cmd.Health (type *container.HealthConfig) to type "github.com/GoogleContainerTools/kaniko/vendor/github.com/google/go-containerregistry/v1".HealthConfig
make: *** [out/executor] Error 2

On go 1.10

[dlorenc]

Hmm, that might be because one is a pointer and the other isn't. Could you give it one more try by dereferencing the h.cmd.Health before converting?

[chrisz100]

Same thing:

test := &h.cmd.Health
converted := v1.HealthConfig(test)

--> 
pkg/commands/healthcheck.go:45:30: cannot convert test (type **container.HealthConfig) to type "github.com/GoogleContainerTools/kaniko/vendor/github.com/google/go-containerregistry/v1".HealthConfig
make: *** [out/executor] Error 2

EDIT:
My bad. That looks better!

[dlorenc]

Nice!