-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/healthcheck signal #177
Changes from all commits
c75ebba
951689f
1686e3b
eac3fe9
1cf9db6
5f93d13
c5071bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
Copyright 2018 Google LLC | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package commands | ||
|
||
import ( | ||
"strings" | ||
|
||
"github.com/GoogleContainerTools/kaniko/pkg/dockerfile" | ||
"github.com/docker/docker/builder/dockerfile/instructions" | ||
"github.com/google/go-containerregistry/v1" | ||
"github.com/sirupsen/logrus" | ||
) | ||
|
||
type HealthCheckCommand struct { | ||
cmd *instructions.HealthCheckCommand | ||
} | ||
|
||
// ExecuteCommand handles command processing similar to CMD and RUN, | ||
func (h *HealthCheckCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error { | ||
logrus.Info("cmd: HEALTHCHECK") | ||
|
||
check := v1.HealthConfig(*h.cmd.Health) | ||
config.Healthcheck = &check | ||
|
||
return nil | ||
} | ||
|
||
// FilesToSnapshot returns an empty array since this is a metadata command | ||
func (h *HealthCheckCommand) FilesToSnapshot() []string { | ||
return []string{} | ||
} | ||
|
||
// CreatedBy returns some information about the command for the image config history | ||
func (h *HealthCheckCommand) CreatedBy() string { | ||
entrypoint := []string{"HEALTHCHECK"} | ||
|
||
return strings.Join(append(entrypoint, strings.Join(h.cmd.Health.Test, " ")), " ") | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the build error, it looks like you'll have to translate from the dockerfile HealthCheck type to the go-containerregistry one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly. Just looking into how to do this the most efficiently.
Just creating a v1.HealthConfig and passing all values would work, but I wouldn't really regard this as future proof or clean tbh. Any alternatives you could think of?