-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HEALTHCHECK command #17
Comments
Healthcheck requires a different config struct: It seems to be not included in the open container specs - thus implementing this would require completely replacing the base for configs. After that - if I get the code right - it would simply mean passing the already prepared HealthConfig struct to the config to persist it. Which shouldn't be hard at all - but that requires HealthCheck to be existent in the container config. Ideas? |
@dlorenc @priyawadhwa any idea? |
Hey, sorry for the late response! We use the go-containerregistry library for working with our images, and right now the config doesn't have a field for Healthcheck. You'd probably have to create the healthcheck config struct in go-containerregistry and add it to the config before starting to implement this command in kaniko. |
So you suggest contributing to go-containerregistry and using the merged version for proceeding here, correct? |
@chrisz100 correct! I can help you get that PR merged into go-containerregistry as well :) |
See #1 for details
The text was updated successfully, but these errors were encountered: