added healthcheck to config struct and healthcheck struct #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlorenc cc |
dlorenc
reviewed
May 14, 2018
| // {"NONE"} : disable healthcheck | ||
| // {"CMD", args...} : exec arguments directly | ||
| // {"CMD-SHELL", command} : run command with system's default shell | ||
| Test []string `json:",omitempty"` |
There was a problem hiding this comment.
nit: should these be lowercased like json:"test,omitempty"
There was a problem hiding this comment.
This is the original implementation from docker - moby/moby
What would adding the test to the json tag change here specifically?
There was a problem hiding this comment.
Ah, basically just to make it lowercase when marshalled, to match the way we marshal all the other values in this file
|
Ah sorry for the back and forth, my coworkers point out that we actually should leave it the way you had it before to match exactly how Docker serializes. After that, this LGTM. |
This reverts commit 94957d1.
dlorenc
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to implement HEALTHCHECK commands to kaniko - see GoogleContainerTools/kaniko#17 (comment)