Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bucket_policy_only to storage_bucket #135

Closed
morgante opened this issue Jul 23, 2019 · 4 comments
Closed

Add bucket_policy_only to storage_bucket #135

morgante opened this issue Jul 23, 2019 · 4 comments
Assignees
@tysen

Comments

@morgante
Copy link
Contributor

GoogleCloudPlatform/magic-modules#1878 needs to be incorporated in the conversion library as well.
@morgante
Copy link
Contributor Author

morgante commented Jul 23, 2019 •
edited
Loading

@tysen Could you take a look at this? We're trying to keep the handwritten resources in sync. /cc @chrisst @rileykarson

@morgante morgante mentioned this issue Jul 23, 2019
Closed
@FanchenBao FanchenBao mentioned this issue Jul 30, 2019
Closed
@morgante morgante mentioned this issue Jul 30, 2019
Closed
@FanchenBao
Copy link
Contributor

FanchenBao commented Jul 30, 2019 •
edited
Loading

I opened a PR in magic-module. I hope this is the right way to fix the issue.

@slevenick
Copy link
Contributor

@morgante does #145 fix this? I'm not particularly familiar with this functionality

@morgante
Copy link
Contributor Author

morgante commented Aug 7, 2019

@slevenick Looks like it should.

@tysen tysen closed this as completed Aug 26, 2019
modular-magician pushed a commit to modular-magician/terraform-google-conversion that referenced this issue Oct 7, 2019
@danawillow
Merge pull request GoogleCloudPlatform#135 from modular-magician/code…
c316f74 
…gen-pr-913

add warning about node pools defined in clusters. See TPG GoogleCloudPlatform#1712.
modular-magician pushed a commit to modular-magician/terraform-google-conversion that referenced this issue Oct 7, 2019
@danawillow @nat-henderson
Merge pull request GoogleCloudPlatform#135 from modular-magician/code…
16e0766 
…gen-pr-913

add warning about node pools defined in clusters. See TPG GoogleCloudPlatform#1712.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tysen tysen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tysen @morgante @slevenick @FanchenBao