Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform Support For Cloud SQL Preferred Zone Selection Feature #1712

Conversation

modular-magician
Copy link
Collaborator

Add Terraform Support For Cloud SQL Preferred Zone Selection Feature

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

composer: added `database_config.zone` field in `google_composer_environment`

Fixes hashicorp/terraform-provider-google/issues/16344

Derived from GoogleCloudPlatform/magic-modules#9468

…(#9468)

* Adding Support for zone selection after api changed

* Fixed build error

* Fixed documentation

---------

Co-authored-by: Khaled Hassan <[email protected]>
[upstream:bc77da041b3075c7d39e0f617a5e68919822fc85]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 16, 2023 17:41
@modular-magician modular-magician requested review from shuyama1 and removed request for a team November 16, 2023 17:41
@modular-magician modular-magician merged commit ced7aee into GoogleCloudPlatform:main Nov 16, 2023
5 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-bc77da041b3075c7d39e0f617a5e68919822fc85 branch November 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Terraform Support For Cloud SQL Preferred Zone Selection Feature
1 participant