Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync storage_bucket.go with resource_storage_bucket.go #145

Merged

Conversation

modular-magician
Copy link
Collaborator

Original Author: @FanchenBao

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@FanchenBao
Copy link
Contributor

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 6, 2019
@slevenick slevenick merged commit c99fe39 into GoogleCloudPlatform:master Aug 7, 2019
modular-magician pushed a commit to modular-magician/terraform-google-conversion that referenced this pull request Oct 7, 2019
Support cloud sql private ip (incorporating previous PR feedback)
modular-magician pushed a commit to modular-magician/terraform-google-conversion that referenced this pull request Oct 7, 2019
Support cloud sql private ip (incorporating previous PR feedback)
@modular-magician modular-magician deleted the codegen-pr-2128 branch November 18, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants