Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python 3.10.0 to the samples image #6813

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Oct 7, 2021

No description provided.

@parthea parthea requested a review from a team as a code owner October 7, 2021 16:58
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@leahecole leahecole linked an issue Oct 7, 2021 that may be closed by this pull request
@leahecole
Copy link
Collaborator

We may see some errors from certain dependencies like numpy - but hopefully not too many

@tswast
Copy link
Contributor

tswast commented Oct 7, 2021

We may see some errors from certain dependencies like numpy - but hopefully not too many

Yeah, BigQuery samples won't be compatible until there are numpy, pyarrow, and pandas releases.

@parthea
Copy link
Collaborator Author

parthea commented Oct 7, 2021

The failure in Kokoro CI - Python 2.7 (App Engine Standard Only) is the same as issue #6702.

==================================== ERRORS ====================================
__________________________ ERROR at setup of test_app __________________________
Traceback (most recent call last):
  File "/workspace/appengine/standard/migration/ndb/overview/main_test.py", line 20, in app
    import main
  File "/workspace/appengine/standard/migration/ndb/overview/main.py", line 17, in <module>
    from google.cloud import ndb
  File "/workspace/appengine/standard/migration/ndb/overview/.nox/py-2-7/lib/python2.7/site-packages/google/cloud/ndb/__init__.py", line 28, in <module>
    from google.cloud.ndb.client import Client
  File "/workspace/appengine/standard/migration/ndb/overview/.nox/py-2-7/lib/python2.7/site-packages/google/cloud/ndb/client.py", line 24, in <module>
    from google.cloud import _helpers
  File "/workspace/appengine/standard/migration/ndb/overview/.nox/py-2-7/lib/python2.7/site-packages/google/cloud/_helpers.py", line 33, in <module>
    from google.protobuf import duration_pb2
  File "/workspace/appengine/standard/migration/ndb/overview/.nox/py-2-7/lib/python2.7/site-packages/google/protobuf/duration_pb2.py", line 5, in <module>
    from google.protobuf import descriptor as _descriptor
  File "/workspace/appengine/standard/migration/ndb/overview/.nox/py-2-7/lib/python2.7/site-packages/google/protobuf/descriptor.py", line 113
    class DescriptorBase(metaclass=DescriptorMetaclass):
                                  ^
SyntaxError: invalid syntax
- generated xml file: /workspace/appengine/standard/migration/ndb/overview/sponge_log.xml -
=========================== 1 error in 0.58 seconds ============================
nox > Command pytest --junitxml=sponge_log.xml failed with exit code 1
nox > Session py-2.7 failed.

@parthea
Copy link
Collaborator Author

parthea commented Oct 7, 2021

The samples_test.py::test_datalab_magic_parameterized_query failure is captured in #6770

@parthea
Copy link
Collaborator Author

parthea commented Oct 8, 2021

There is a failure with composer/blog/gcp-tech-blog/data-orchestration-with-composer. I don't see it tracked already. I'm going to try bumping the minimum version of Flask-OpenID from 1.2.5 to 1.3.0 to see if that fixes it.

Collecting Flask-OpenID==1.2.5
  Downloading Flask-OpenID-1.2.5.tar.gz (43 kB)
    ERROR: Command errored out with exit status 1:
     command: /workspace/composer/blog/gcp-tech-blog/data-orchestration-with-composer/.nox/py-3-8/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-j24_ro1o/flask-openid/setup.py'"'"'; __file__='"'"'/tmp/pip-install-j24_ro1o/flask-openid/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-t1yzvvtp
         cwd: /tmp/pip-install-j24_ro1o/flask-openid/
    Complete output (1 lines):
    error in Flask-OpenID setup command: use_2to3 is invalid.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 20.2.4; however, version 21.2.4 is available.
You should consider upgrading via the '/workspace/composer/blog/gcp-tech-blog/data-orchestration-with-composer/.nox/py-3-8/bin/python -m pip install --upgrade pip' command.
nox > Session py-3.8 failed.
PWD: /workspace/composer/blog/gcp-tech-blog/data-orchestration-with-composer

@parthea parthea merged commit 84d7cb5 into master Oct 8, 2021
@parthea parthea deleted the parthea-patch-1 branch October 8, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 to the Docker image once it's GA
5 participants