Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Add kokoro configs for python 3.10 samples testing #1239

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 7, 2021

No description provided.

@parthea parthea requested a review from a team as a code owner October 7, 2021 12:48
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@parthea
Copy link
Contributor Author

parthea commented Oct 7, 2021

I've confirmed this configuration works in python-apigee-connect. See googleapis/python-apigee-connect#51

@busunkim96
Copy link
Contributor

For any repos with real samples (apigee-connect doesn't have any samples) the 3.10 check will fail until the samples Docker image has python 3.10.

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.kokoro/docker/Dockerfile

@parthea
Copy link
Contributor Author

parthea commented Oct 7, 2021

Good catch! This will be added in GoogleCloudPlatform/python-docs-samples#6813

@parthea parthea merged commit c6e69c4 into master Oct 8, 2021
@parthea parthea deleted the add-kokoro-configs-for-python-3-10 branch October 8, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants