Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10 to the Docker image once it's GA #6762

Closed
leahecole opened this issue Sep 29, 2021 · 2 comments · Fixed by #6813
Closed

Add Python 3.10 to the Docker image once it's GA #6762

leahecole opened this issue Sep 29, 2021 · 2 comments · Fixed by #6813
Assignees
@leahecole
Labels
samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@leahecole
Copy link
Collaborator

Once Python 3.10 is released, we need to update to install it

python-docs-samples/.kokoro/docker/Dockerfile

Line 120 in 9698be4

&& for PYTHON_VERSION in 2.7.18 3.6.13 3.7.10 3.8.8 3.9.2; do \

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 29, 2021
@leahecole
Copy link
Collaborator Author

And once that change is put through, message the DPEs to let them know on the thread that I made 🐍

@busunkim96 busunkim96 added the type: process A process-related concern. May include testing, release, or the like. label Sep 29, 2021
@busunkim96 busunkim96 mentioned this issue Sep 29, 2021
Merged
8 tasks
@leahecole leahecole assigned leahecole and unassigned nicain Sep 30, 2021
This was referenced Oct 5, 2021
Merged
Merged
@leahecole
Copy link
Collaborator Author

I did run some tests with 3.10 in the Docker image against my composer samples and they failed because numpy doesn't support 3.10 yet. When I get some spare time (ha) I will run against all samples to see how many it fails on and if it's only a handful, to enable it but expect failures (and not require the check), or, if it's failing on the majority of samples, wait to enable it a bit longer.

@leahecole leahecole linked a pull request Oct 7, 2021 that will close this issue
feat: add python 3.10.0 to the samples image #6813
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leahecole leahecole

Labels
samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add python 3.10.0 to the samples image GoogleCloudPlatform/python-docs-samples
3 participants
@nicain @leahecole @busunkim96