Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ppai/timeseries-classification): add global fishing watch sample #6557

Merged

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Aug 12, 2021

Description

Add Global Fishing Watch sample for the People & Planet AI Series.

Staged:

  • Notebook -- this serves as the README

    ⚠️ When cloning the repo, it doesn't exist yet in the main branch, so replace with:

    !git clone --branch ppai-timeseries-classification https://github.com/davidcavazos/python-docs-samples.git ~/python-docs-samples
    

    The links to source files in the notebook will also be broken since the files don't exist yet in the main branch.

Checklist

@davidcavazos
Copy link
Contributor Author

It looks like dropping the last batch with possibly incomplete number of elements solved the flaky issue.

@davidcavazos
Copy link
Contributor Author

@dinagraves @busunkim96 -- tests are passing now, they should no longer be flaky.

@busunkim96
Copy link
Contributor

Admin Merging -

@davidcavazos is a CODEOWNER for this product area and the PR was also reviewed by @nikitamaia.

The 3.10 failure is expected as that job is not yet fully configured, see #6762.

The 3.8 failure is due to a timeout that occurred after the tests passed. (see log)

============================= test session starts ==============================
platform linux -- Python 3.8.8, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /workspace/people-and-planet-ai/timeseries-classification/.nox/py-3-8/bin/python
cachedir: .pytest_cache
rootdir: /workspace, configfile: pytest.ini
plugins: forked-1.3.0, xdist-2.3.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I

[gw0] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw1] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw2] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw3] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw4] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw5] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw6] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw7] linux Python 3.8.8 cwd: /workspace/people-and-planet-ai/timeseries-classification

[gw0] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw1] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw2] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw3] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw4] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw5] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw6] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]

[gw7] Python 3.8.8 (default, Mar 26 2021, 10:10:50)  -- [GCC 9.3.0]
gw0 [7] / gw1 [7] / gw2 [7] / gw3 [7] / gw4 [7] / gw5 [7] / gw6 [7] / gw7 [7]

scheduling tests via LoadScheduling

local_test.py::test_validated_incompatible_shape 
local_test.py::test_validated_ok 
e2e_test.py::test_predict 
local_test.py::test_validated_incompatible_type 
[gw3] [ 14%] PASSED local_test.py::test_validated_incompatible_shape 
local_test.py::test_serialize_deserialize 
[gw2] [ 28%] PASSED local_test.py::test_validated_incompatible_type 
local_test.py::test_e2e_local 
[gw4] [ 42%] PASSED local_test.py::test_validated_ok 
local_test.py::test_validated_missing_field 
[gw1] [ 57%] PASSED local_test.py::test_validated_missing_field 
[gw5] [ 71%] PASSED local_test.py::test_serialize_deserialize 
[gw6] [ 85%] PASSED local_test.py::test_e2e_local 
[gw0] [100%] PASSED e2e_test.py::test_predict 

=============================== warnings summary ===============================
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22
  /workspace/people-and-planet-ai/timeseries-classification/.nox/py-3-8/lib/python3.8/site-packages/tensorflow/python/autograph/impl/api.py:22: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696
  /workspace/people-and-planet-ai/timeseries-classification/.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:696: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    if not isinstance(type_params, collections.Iterable):

.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535
  /workspace/people-and-planet-ai/timeseries-classification/.nox/py-3-8/lib/python3.8/site-packages/apache_beam/typehints/typehints.py:535: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    if not isinstance(type_params, (collections.Sequence, set)):

-- Docs: https://docs.pytest.org/en/stable/warnings.html
- generated xml file: /workspace/people-and-planet-ai/timeseries-classification/sponge_log.xml -
================= 7 passed, 24 warnings in 1733.28s (0:28:53) ==================
nox > Session py-3.8 was successful.


err: signal: killed


#
# Summary 
#

SUCCESS: 0, FAILURE: 1, SKIPPED: 0, ERROR: 0, ��
people-and-planet-ai/timeseries-classification........................[ FAILURE]
================================================================
2021-09-29T19:54:27Z: Build finished with 2 
================================================================

@busunkim96 busunkim96 merged commit 1586e1e into GoogleCloudPlatform:master Sep 29, 2021
@davidcavazos davidcavazos deleted the ppai-timeseries-classification branch September 29, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants