-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map faas.* attributes to generic_task in resource mapping #273
Merged
dashpole
merged 5 commits into
GoogleCloudPlatform:main
from
dashpole:faas_to_generic_task
Sep 28, 2023
Merged
Map faas.* attributes to generic_task in resource mapping #273
dashpole
merged 5 commits into
GoogleCloudPlatform:main
from
dashpole:faas_to_generic_task
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
faas_to_generic_task
branch
4 times, most recently
from
August 22, 2023 18:04
c2757b2
to
0bebac5
Compare
Ideally: If a user sets a service.name, use that. Otherwise, fall back to faas.name. Options:
|
I've proposed option 2 in a design document. |
dashpole
force-pushed
the
faas_to_generic_task
branch
6 times, most recently
from
August 31, 2023 20:38
41279e6
to
4f2b35b
Compare
dashpole
force-pushed
the
faas_to_generic_task
branch
7 times, most recently
from
September 19, 2023 16:27
36d6119
to
f235f3b
Compare
dashpole
force-pushed
the
faas_to_generic_task
branch
from
September 19, 2023 16:30
f235f3b
to
12131df
Compare
I think this is good to go @aabmass. |
aabmass
reviewed
Sep 21, 2023
...ry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_mapping.py
Outdated
Show resolved
Hide resolved
...ry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_mapping.py
Outdated
Show resolved
Hide resolved
dashpole
force-pushed
the
faas_to_generic_task
branch
from
September 22, 2023 16:18
528f845
to
4ea1d6d
Compare
aabmass
reviewed
Sep 22, 2023
...ry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_mapping.py
Show resolved
Hide resolved
...ry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_mapping.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
Question: should faas.* attributes take precedence over service.* attributes if they are present? If they do, it might break users who are currently using service.* attributes. If we don't, the default service (unknown) will take precedence over faas.name