We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GoogleCloudPlatform/opentelemetry-operations-python#273 in the resource mapping in this repository.
The text was updated successfully, but these errors were encountered:
idk if this issue refers to the same problem I am describing below, but I am going to report it anyway :)
As I was reading the code to understand why cloud_run metrics are logged as generic_node instead of generic_task I came to believe that every instance of semconv.FaaSIDKey in https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/main/internal/resourcemapping/resourcemapping.go should actually be changed to semconv.FaaSInstanceKey
generic_node
generic_task
semconv.FaaSIDKey
semconv.FaaSInstanceKey
Any thoughts on this?
Sorry, something went wrong.
You are correct. That was definitely an oversight during #679. I'll make sure that is fixed as well. Thanks for pointing it out.
dashpole
Successfully merging a pull request may close this issue.
Implement GoogleCloudPlatform/opentelemetry-operations-python#273 in the resource mapping in this repository.
The text was updated successfully, but these errors were encountered: