Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept faas.name and faas.id for mapping metrics to generic_task #272

Closed
dashpole opened this issue Aug 22, 2023 · 0 comments · Fixed by #273
Closed

Accept faas.name and faas.id for mapping metrics to generic_task #272

dashpole opened this issue Aug 22, 2023 · 0 comments · Fixed by #273
Assignees
Labels
enhancement New feature or request priority: p1

Comments

@dashpole
Copy link
Contributor

In order to map to generic_task on cloud run, cloud functions, and GAE, we need to map from faas.name and faas.id to generic_task, similar to what we do for service.name and service.instance.id

Example in golang:

https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/ef9b15e0c12cee086ab8a6e7439e64258b029a3b/internal/resourcemapping/resourcemapping.go#L228-L235

Current implementation:

# fallback to generic_task
if (
ResourceAttributes.SERVICE_NAME in attrs
and ResourceAttributes.SERVICE_INSTANCE_ID in attrs
):
mr = _create_monitored_resource(_constants.GENERIC_TASK, attrs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant