-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for IAM Group authentication to google_sql_user #9578
Conversation
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-)) |
Redo of #9505 |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
minor formatting changes
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests:
|
Minor formatting changes
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests:
|
Why was this reverted? I need to codify google_sql_user with type of CLOUD_IAM_GROUP_SERVICE_ACCOUNT :-( |
At the time of implementation it wasn't actually supported yet (and was not caught in review due to the test for it being skipped), the service team contributor partially reimplemented it via the following: #9685. @pratikgarg10 may have more details here. |
Release Note Template for Downstream PRs (will be copied)