Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for IAM Group authentication to google_sql_user #9578

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

pratikgarg10
Copy link
Member

@pratikgarg10 pratikgarg10 commented Dec 4, 2023

Release Note Template for Downstream PRs (will be copied)

sql: added support for IAM GROUP authentication in the `type` field of `google_sql_user`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@pratikgarg10 pratikgarg10 marked this pull request as draft December 4, 2023 20:23
@pratikgarg10 pratikgarg10 marked this pull request as ready for review December 4, 2023 20:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-))

@NickElliot NickElliot requested review from NickElliot and removed request for shuyama1 December 4, 2023 21:21
@NickElliot
Copy link
Contributor

Redo of #9505

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3258
Passed tests 2925
Skipped tests: 332
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 34 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3260
Passed tests 2928
Skipped tests: 332
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Minor formatting changes
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3261
Passed tests 2929
Skipped tests: 332
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@NickElliot NickElliot changed the title Main add support for IAM Group authentication to google_sql_user Dec 5, 2023
NickElliot added a commit that referenced this pull request Dec 7, 2023
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@lodotek
Copy link

lodotek commented May 30, 2024

Why was this reverted? I need to codify google_sql_user with type of CLOUD_IAM_GROUP_SERVICE_ACCOUNT :-(

@NickElliot
Copy link
Contributor

At the time of implementation it wasn't actually supported yet (and was not caught in review due to the test for it being skipped), the service team contributor partially reimplemented it via the following: #9685. @pratikgarg10 may have more details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants