Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v5.9.0 #16752

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Dec 8, 2023

Notes:

Copy link

github-actions bot commented Dec 8, 2023

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@SarahFrench
Copy link
Member Author

SarahFrench commented Dec 8, 2023

I've run the TestAccSqlUser_mysql test, which was failing due to the PR that was reverted, here in TeamCity: TestAccSqlUser_mysql test run on release-5.9.0 branch

The test passed due to the revert commit being picked into the release branch

@SarahFrench SarahFrench changed the title Update CHANGELOG.md Update CHANGELOG.md for v5.9.0 Dec 8, 2023
@SarahFrench SarahFrench requested review from shuyama1 and removed request for ScottSuarez December 8, 2023 18:07
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
SarahFrench and others added 2 commits December 8, 2023 18:29
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
* cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643))
* container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623))
* container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653))
* dlp: updated required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean for the user?

Is it a bug fix or an enhancement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've clarified that release note and split it into:

  • dlp: added conflicting field validation in the storage_config.timespan_config block in data_loss_prevention_job_trigger resource (#16628)
  • dlp: updated the storage_config.timespan_config.timestamp_field field in data_loss_prevention_job_trigger to be optional (#16628)

I've moved them to bug fix as the provider wasn't validating fields correctly

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@shuyama1 shuyama1 merged commit 4a8a493 into release-5.9.0 Dec 11, 2023
1 check passed
@shuyama1 shuyama1 deleted the SarahFrench-release-5.9.0-changelog branch December 11, 2023 17:32
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants