Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for IAM Group authentication to google_sql_user #9505

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

pratikgarg10
Copy link
Member

@pratikgarg10 pratikgarg10 commented Nov 21, 2023

Release Note Template for Downstream PRs (will be copied)

sql: added support for IAM GROUP authentication in the `type` field of `google_sql_user`

@pratikgarg10 pratikgarg10 changed the title Iam group auth add support for IAM Group authentication to google_sql_user Nov 21, 2023
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3236
Passed tests 2905
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlUser_postgresIAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 27 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 27 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3237
Passed tests 2906
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlUser_postgresIAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 17 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3237
Passed tests 2907
Skipped tests: 330
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple formatting changes needed but also wanted to ask one thing for clarification:
the test case with "CLOUD_IAM_GROUP_USER" was removed after the test failure above saying it was not an allowed user type -- was that an issue with just that particular instance/permissions on the test project, or is there other necessary pre requisites for creating an IAM_GROUP_USER

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 17 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 3 deletions(-))

@pratikgarg10
Copy link
Member Author

A couple formatting changes needed but also wanted to ask one thing for clarification: the test case with "CLOUD_IAM_GROUP_USER" was removed after the test failure above saying it was not an allowed user type -- was that an issue with just that particular instance/permissions on the test project, or is there other necessary pre requisites for creating an IAM_GROUP_USER

Updated formatting changes. The reverted test was for postgresql which is currently not supported.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3237
Passed tests 2906
Skipped tests: 331
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then!

NickElliot added a commit that referenced this pull request Nov 29, 2023
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants