Auto-generate BgpPeer #2434

drebes · 2019-10-05T21:57:09Z

Fixes hashicorp/terraform-provider-google#4954

Release Note Template for Downstream PRs (will be copied)

`compute`: field `peer_ip_address` in `google_compute_router_peer` is now required, to match the API behavior.

`compute`: field `advertised_ip_ranges` in `google_compute_router_peer` can now be updated without recreating the resource.

`compute`: computed attribute `management_type` in `google_compute_router_peer` is now available.

modular-magician · 2019-10-08T12:55:00Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cba7b4c.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.

modular-magician · 2019-10-08T13:21:04Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3885cb1.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

products/compute/terraform.yaml

slevenick · 2019-10-17T16:53:13Z

There are a couple differences in the schema on the downstream generated resource, specifically the removal of ForceNew: true, on advertise_mode and advertised_groups. Are these things that can be modified now?

slevenick · 2019-10-21T17:02:36Z

Fixes: hashicorp/terraform-provider-google#4692

modular-magician · 2019-11-11T21:02:49Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 874e765.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.

drebes · 2019-11-11T21:02:59Z

I did some testing and indeed advertise_mode and advertised_groups cannot be updated in one go, so a delete and create is needed (technically two patches on the router resource). I've set them back to ForceNew: true.

danawillow · 2019-11-15T22:26:00Z

Hey @drebes, we just did a bunch of work for 3.0 which means that the current downstreams for this are out of date. When you get the chance, can you do a rebase of this PR onto master? I'm going to close the existing downstreams to make sure that we get diffs on top of the current HEAD in the next magician run.

modular-magician · 2019-11-15T22:51:29Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b0fde92.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1396
depends: hashicorp/terraform-provider-google#4923

drebes · 2019-11-15T22:52:07Z

Done. I've also updated the ID format to what I understand is the standard format for 3.0.0.

products/compute/api.yaml

products/compute/terraform.yaml

danawillow · 2019-11-20T00:17:34Z

Looks like you'll need to resolve the merge conflicts before the magician will run again.

modular-magician · 2019-11-20T00:33:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1f6d4fe.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-22T09:18:31Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8ab2ad2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

drebes · 2019-11-22T09:49:53Z

Just rebased.

danawillow

Can you also update the release note according to the guidelines at https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md? We want CHANGELOG entries to be for user-visible changes, so no need for a general "is now autogenerated" one, but we probably do want a breaking-change note for peer_ip_address (since it was optional before, even though people's configs wouldn't apply correctly without it). It also looks like a few things that weren't updatable before now are, and a new computed field management_type was added, so those can have enhancement notes.

third_party/terraform/website-compiled/google.erb

products/compute/api.yaml

drebes · 2019-11-25T15:04:05Z

CHANGELOG comments updated. Fixes hashicorp/terraform-provider-google#4954

modular-magician · 2019-11-25T15:06:16Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b8577d0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

drebes · 2019-11-25T15:13:12Z

Also, should we add a note about the changed ID format for 3.0.0 or this will be noted for all resources?

danawillow · 2019-11-26T22:38:04Z

We have a note already about the changed ID format at https://www.terraform.io/docs/providers/google/guides/version_3_upgrade.html#id-format-changes
so I think it's fine as-is

modular-magician · 2019-11-26T22:55:28Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, df3144d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

drebes requested a review from danawillow October 5, 2019 21:57

googlebot added the cla: yes label Oct 5, 2019

drebes force-pushed the bgp-peer branch 2 times, most recently from faeebec to cba7b4c Compare October 8, 2019 12:45

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Oct 8, 2019

drebes requested a review from slevenick October 15, 2019 22:30

drebes mentioned this pull request Oct 17, 2019

Router Peer peer_ip_address is required #2482

Closed

slevenick reviewed Oct 17, 2019

View reviewed changes

products/compute/terraform.yaml Outdated Show resolved Hide resolved

drebes force-pushed the bgp-peer branch from 3885cb1 to 25cff27 Compare November 11, 2019 20:28

modular-magician added the terraform-google-conversion label Nov 11, 2019

This was referenced Nov 15, 2019

Auto-generate BgpPeer GoogleCloudPlatform/terraform-google-conversion#256

Closed

Auto-generate BgpPeer hashicorp/terraform-provider-google#4630

Closed

Auto-generate BgpPeer hashicorp/terraform-provider-google-beta#1241

Closed

drebes force-pushed the bgp-peer branch from 874e765 to b0fde92 Compare November 15, 2019 22:40

danawillow reviewed Nov 19, 2019

View reviewed changes

drebes force-pushed the bgp-peer branch from ff5dc88 to 1f6d4fe Compare November 20, 2019 00:24

slevenick mentioned this pull request Nov 20, 2019

google_compute_router_peer keeps being destroyed and recreated when advertised_ip_ranges is changed hashicorp/terraform-provider-google#4954

Closed

drebes force-pushed the bgp-peer branch from 1f6d4fe to 8ab2ad2 Compare November 22, 2019 09:07

danawillow approved these changes Nov 22, 2019

View reviewed changes

third_party/terraform/website-compiled/google.erb Outdated Show resolved Hide resolved

products/compute/api.yaml Show resolved Hide resolved

modular-magician added the automerged label Nov 26, 2019

drebes and others added 16 commits November 26, 2019 23:12

Auto-generate BgpPeer

ce63cf3

Exclude RouterBgpPeer from inspect

1c768a3

Exclude RouterBgpPeer from ansible

b394b0f

make advertiseMode and advertisedIpRanges non-updateable.

680218a

use legacy id format for resource_compute_router_peer

a89952b

Exclude RouterBgpPeer from ansible

962c860

adapt RouterBgpPeer id to 3.0.0 format

857d80f

remote redundant CRUD urls

6ca0cb4

fix peer ip address description, make ip address computed

e6ad7d7

make ip address available for Terraform

18eeb7e

add info about default region to description

5a5093f

make RouterBgpPeer test filename consistent

dd97fd4

make advertised_ip_ranges.range required

247640b

fix google_compute_router_peer sidebar link

4996c9a

quote regexp so markdown parser doesn't think it's a link

88d4d4f

Update tracked submodules -> HEAD on Tue Nov 26 23:12:32 UTC 2019

538d316

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the bgp-peer branch from df3144d to 538d316 Compare November 26, 2019 23:12

modular-magician merged commit bc59530 into GoogleCloudPlatform:master Nov 26, 2019

drebes mentioned this pull request Dec 7, 2019

Make ipAddress field editable #2767

Closed

drebes deleted the bgp-peer branch December 14, 2019 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-generate BgpPeer #2434

Auto-generate BgpPeer #2434

drebes commented Oct 5, 2019 •

edited by danawillow

Loading

modular-magician commented Oct 8, 2019 •

edited by danawillow

Loading

modular-magician commented Oct 8, 2019

slevenick commented Oct 17, 2019

slevenick commented Oct 21, 2019

modular-magician commented Nov 11, 2019 •

edited by danawillow

Loading

drebes commented Nov 11, 2019

danawillow commented Nov 15, 2019

modular-magician commented Nov 15, 2019

drebes commented Nov 15, 2019

danawillow commented Nov 20, 2019

modular-magician commented Nov 20, 2019

modular-magician commented Nov 22, 2019

drebes commented Nov 22, 2019

danawillow left a comment

drebes commented Nov 25, 2019

modular-magician commented Nov 25, 2019

drebes commented Nov 25, 2019

danawillow commented Nov 26, 2019

modular-magician commented Nov 26, 2019

Auto-generate BgpPeer #2434

Auto-generate BgpPeer #2434

Conversation

drebes commented Oct 5, 2019 • edited by danawillow Loading

modular-magician commented Oct 8, 2019 • edited by danawillow Loading

Pull request statuses

New Pull Requests

modular-magician commented Oct 8, 2019

Pull request statuses

New Pull Requests

slevenick commented Oct 17, 2019

slevenick commented Oct 21, 2019

modular-magician commented Nov 11, 2019 • edited by danawillow Loading

Pull request statuses

New Pull Requests

drebes commented Nov 11, 2019

danawillow commented Nov 15, 2019

modular-magician commented Nov 15, 2019

Pull request statuses

New Pull Requests

drebes commented Nov 15, 2019

danawillow commented Nov 20, 2019

modular-magician commented Nov 20, 2019

Pull request statuses

New Pull Requests

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

drebes commented Nov 22, 2019

danawillow left a comment

Choose a reason for hiding this comment

drebes commented Nov 25, 2019

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

drebes commented Nov 25, 2019

danawillow commented Nov 26, 2019

modular-magician commented Nov 26, 2019

Pull request statuses

New Pull Requests

drebes commented Oct 5, 2019 •

edited by danawillow

Loading

modular-magician commented Oct 8, 2019 •

edited by danawillow

Loading

modular-magician commented Nov 11, 2019 •

edited by danawillow

Loading