Make ipAddress field editable

[selslack]

Release Note Template for Downstream PRs (will be copied)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[selslack]

@rambleraptor can you please take a look?

[rambleraptor]

Hello! I'll get this running through our CI system now.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a28c9ea.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1469
depends: hashicorp/terraform-provider-google#5077

[selslack]

@rambleraptor

Thanks!

I've actually dig deeper into this and I found out that ip_range field actually used by GCP API to extract a local interface address.

IP address and range of the interface. The IP range must be in the RFC3927 link-local IP address space. The value must be a CIDR-formatted string, for example: 169.254.0.1/30.

NOTE: Do not truncate the address as it represents the IP address of the interface.

(see the NOTE)

I'm going to propose documentation improvements for google_compute_router_interface (which is outside of this repo) instead.

I'm still not sure if it makes sense to have this field editable. It's definitely not [Output Only] according to the API docs. How we can find out the actual meaning of bgpPeers[].ipAddress field? Will it override interface's ip_range?

[drebes]

Chiming in since we discussed this as part of the PR that autogenerates BGP peer. The ipAddress is not configurable for Terraform when we specify the interface name, AFAIK. We could mark it as input: true in api.yaml and override to false for Terraform. If you still want to make it editable (for ansible?), I'd suggest adding some acceptance test adding an update of ipAddress.