Problem about field peer_ip_address in resource google_compute_router_peer

[maqiuyujoyce]

Field peer_ip_address in resource google_compute_router_peer is marked as "Required" in the doc, however, it is "Optional" in the schema. This happens in both GA and Beta. It is pretty confusing and I'm not sure which one I should follow. Could you fix it?

[slevenick]

I believe it should be required, but I don't know enough about bgp peers to answer definitively.

Is there a reason you would want to create one without a peer_ip_address?

[maqiuyujoyce]

I agree that it should be required and I don't want to create one without a peer_ip_address. But the schema said it is optional so this required field cannot be enforced in the config. That's why I wondered if it is a bug and if it can be fixed.

[slevenick]

Yes, it should be required. We are reworking this resource at the moment, and the new version will have the field correctly marked as required.

[selslack]

@slevenick can you please clarify why ip_address field of google_compute_router_peer is read-only?

It's editable in the API (I guess, it's bgpPeers[].ipAddress) and in the Cloud Console.

If it's a mistake, can you please fix it as well?

[slevenick]

I don't believe it is editable because it is assigned when the peer is created. The gcloud command doesn't allow you to specify the ip_address field either: https://cloud.google.com/sdk/gcloud/reference/compute/routers/add-bgp-peer

Why do you want to be able to set this field?

[selslack]

@slevenick it's definitely editable here:
.

I'm setting up Site-to-Site VPN with AWS, the default value provided by GCP is not correct in that case (it's the first address in the subnet).

[slevenick]

I'm not very familiar with that field, and I think it is a separate issue from this one. Feel free to file a request for enhancement to make the ip_address field editable, it should be much easier now that we are generating the BgpPeer resource

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!