-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terraform] Add custom Service Account support to Dataflow Job resource #1436
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. |
I confirm I signed the CLA. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLAs should be fine, the third_party/
directory maintains a different license than the mainline repo where they're required. Thanks for contributing!
36d7e44
to
5fd5e66
Compare
Hmm- looks like the Magician got confused while merging. I'll work this out shortly. |
Co-authored-by: Mikael Gibert <[email protected]>
5fd5e66
to
13afb86
Compare
@whd You created this PR from the I'm going to close this PR and use #1551 to merge in the changes. |
Fixes hashicorp/terraform-provider-google#2072
Hopefully supersedes: hashicorp/terraform-provider-google#2071 hashicorp/terraform-provider-google#3009
Refiled here per hashicorp/terraform-provider-google#1834 (comment)
[all]
[terraform]
Add custom Service Account support to Dataflow Job resource
[terraform-beta]
Add custom Service Account support to Dataflow Job resource
[ansible]
[inspec]