Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform] Add custom Service Account support to Dataflow Job resource #1436

Closed
wants to merge 1 commit into from

Conversation

whd
Copy link

@whd whd commented Feb 27, 2019

Fixes hashicorp/terraform-provider-google#2072
Hopefully supersedes: hashicorp/terraform-provider-google#2071 hashicorp/terraform-provider-google#3009
Refiled here per hashicorp/terraform-provider-google#1834 (comment)


[all]

[terraform]

Add custom Service Account support to Dataflow Job resource

[terraform-beta]

Add custom Service Account support to Dataflow Job resource

[ansible]

[inspec]

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@whd
Copy link
Author

whd commented Feb 27, 2019

I had spoken previously with @migibert about my intent to submit this. @migibert please confirm your consent for the CLA bot, thanks.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@migibert
Copy link

I confirm I signed the CLA.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 36d7e44.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#527
depends: hashicorp/terraform-provider-google#3238
depends: modular-magician/ansible#214

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAs should be fine, the third_party/ directory maintains a different license than the mainline repo where they're required. Thanks for contributing!

@rileykarson
Copy link
Member

Hmm- looks like the Magician got confused while merging. I'll work this out shortly.

@chrisst
Copy link
Contributor

chrisst commented Mar 20, 2019

@whd You created this PR from the master branch on your fork, which is a protected branch. Our automation needs to be able to update the branch that created the PR in order to merge the changes but it can't because the branch the PR came from is protected.

I'm going to close this PR and use #1551 to merge in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants