-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add machine_type configuration to google_dataflow_job #1834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be fetched from Read?
what's missing to get this merged? Also would there be a way to do the same for disk size, autoscaling algorithm and initial number of workers? |
Sorry for the delay - we've had some large changes happen recently and now all of our code is being generated through Magic Modules (repo) in order to allow for autogeneration of some resources and versioned providers. However, it means we've lost track of some PRs, especially those that need to be transferred over to the new code location in Magic Modules (for example, the resource_dataflow_job.go file). We haven't had the time yet to get to these reviews or to transfer them over ourselves. If someone from the community needs it sooner than we get to it, please feel free to try opening a PR against MM and we'll help walk you through the new process for contributing. Thank you! |
Hi @propan, if you're still interested in this PR, I believe the outstanding need is to set the field in the read function (and merge/rebase on master). If I don't hear back within the week, I'll go ahead and close this so someone else can get to it. |
Merged here: GoogleCloudPlatform/magic-modules#1862 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Would be quite convenient to have that feature.