-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom Service Account support to Dataflow Job resource #2071
Add custom Service Account support to Dataflow Job resource #2071
Conversation
Config: testAccDataflowJobWithServiceAccount, | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccDataflowJobExists( | ||
"google_dataflow_job.big_data"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this is just checking that the job exists, not that the service account was set successfully. Is this something that could get updated?
Ping @migibert - there's a chance you might not have seen the response here. Let us know if you plan to continue! |
Sorry for giving no news, I tried to add the relevant test but did not succeed. |
Giving up at this point, I run out of time and cannot make this work as I would like... |
Closing as this has been supersede by #3009 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #2072