Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak TestAccBigQueryDataset_withProvider5 #12146

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Unbreak TestAccBigQueryDataset_withProvider5 #12146

merged 1 commit into from
Oct 29, 2024

Conversation

SirGitsalot
Copy link
Member

The test was using a config shared with v6+ tests and was setting the attribution label, which doesn't work pre v6.

@SirGitsalot SirGitsalot requested a review from c2thorn October 25, 2024 23:38
@SirGitsalot SirGitsalot mentioned this pull request Oct 25, 2024
Closed
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 14 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 121
Passed tests: 111
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • bigquery

🟢 All tests passed!

View the build log

wj-chen
wj-chen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@wj-chen wj-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@SirGitsalot SirGitsalot merged commit 832a0d6 into GoogleCloudPlatform:main Oct 29, 2024
12 checks passed
@SirGitsalot SirGitsalot deleted the issue-20005 branch October 29, 2024 17:25
This was referenced Oct 29, 2024
Merged
Merged
Merged
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Nov 1, 2024
@SirGitsalot @niharika-98
Unbreak TestAccBigQueryDataset_withProvider5 (GoogleCloudPlatform#12146)
dd067b7
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
@SirGitsalot @BBBmau
Unbreak TestAccBigQueryDataset_withProvider5 (GoogleCloudPlatform#12146)
7764c42
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
@SirGitsalot @akshat-jindal-nit
Unbreak TestAccBigQueryDataset_withProvider5 (GoogleCloudPlatform#12146)
061ae08
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@SirGitsalot @amanMahendroo
Unbreak TestAccBigQueryDataset_withProvider5 (GoogleCloudPlatform#12146)
bd421a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wj-chen wj-chen wj-chen approved these changes

@c2thorn c2thorn c2thorn approved these changes

Assignees
No one assigned
Labels
service/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SirGitsalot @modular-magician @c2thorn @wj-chen