Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak TestAccBigQueryDataset_withProvider5 #12146

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Unbreak TestAccBigQueryDataset_withProvider5 #12146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func TestAccBigQueryDataset_withProvider5(t *testing.T) {
CheckDestroy: testAccCheckBigQueryDatasetDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccBigQueryDataset_withoutLabels(datasetID),
Config: testAccBigQueryDataset_withoutLabelsV4(datasetID),
ExternalProviders: oldVersion,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckNoResourceAttr("google_bigquery_dataset.test", "labels.%"),
Expand Down Expand Up @@ -509,6 +509,19 @@ resource "google_bigquery_dataset" "test" {
`, datasetID)
}

func testAccBigQueryDataset_withoutLabelsV4(datasetID string) string {
return fmt.Sprintf(`
resource "google_bigquery_dataset" "test" {
dataset_id = "%s"
friendly_name = "foo"
description = "This is a foo description"
location = "EU"
default_partition_expiration_ms = 3600000
default_table_expiration_ms = 3600000
}
`, datasetID)
}

func testAccBigQueryDataset(datasetID string) string {
return fmt.Sprintf(`
resource "google_bigquery_dataset" "test" {
Expand Down
Loading