Failing test(s): TestAccBigQueryDataset_withProvider5

[SarahFrench]

Impacted tests

• TestAccBigQueryDataset_withProvider5

Affected Resource(s)

• google_bigquery_dataset

Failure rates

• 100% since 2024-08-23

Message(s)

------- Stdout: -------
=== RUN   TestAccBigQueryDataset_withProvider5
=== PAUSE TestAccBigQueryDataset_withProvider5
=== CONT  TestAccBigQueryDataset_withProvider5
    resource_bigquery_dataset_test.go:166: Step 1/2 error: Error running pre-apply refresh: exit status 1
        Error: Unsupported argument
          on terraform_plugin_test.tf line 14, in provider "google":
          14:   add_terraform_attribution_label = false
        An argument named "add_terraform_attribution_label" is not expected here.
--- FAIL: TestAccBigQueryDataset_withProvider5 (4.24s)
FAIL

Nightly build test history

https://hashicorp.teamcity.com/test/-9079369578491790535?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_NIGHTLYTESTS&expandTestHistoryChartSection=true

b/375372322

[SarahFrench]

This test looks like it dates from the 5.0.0 major release

[SarahFrench]

The problem is due to the test trying to use a new provider-level argument that was added in 5.0.0 with a 4.x.x version of the provider:

terraform-provider-google/google/services/bigquery/resource_bigquery_dataset_test.go

Lines 154 to 193 in 02de6d5

	func TestAccBigQueryDataset_withProvider5(t *testing.T) {
	acctest.SkipIfVcr(t)
	t.Parallel()
	datasetID := fmt.Sprintf("tf_test_%s", acctest.RandString(t, 10))
	oldVersion := map[string]resource.ExternalProvider{
	"google": {
	VersionConstraint: "4.75.0", // a version that doesn't separate user defined labels and system labels
	Source: "registry.terraform.io/hashicorp/google",
	},
	}
	acctest.VcrTest(t, resource.TestCase{
	PreCheck: func() { acctest.AccTestPreCheck(t) },
	CheckDestroy: testAccCheckBigQueryDatasetDestroyProducer(t),
	Steps: []resource.TestStep{
	{
	Config: testAccBigQueryDataset_withoutLabels(datasetID),
	ExternalProviders: oldVersion,
	Check: resource.ComposeTestCheckFunc(
	resource.TestCheckNoResourceAttr("google_bigquery_dataset.test", "labels.%"),
	resource.TestCheckNoResourceAttr("google_bigquery_dataset.test", "effective_labels.%"),
	),
	},
	{
	Config: testAccBigQueryDataset(datasetID),
	ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
	Check: resource.ComposeTestCheckFunc(
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "labels.%", "2"),
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "labels.env", "foo"),
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "labels.default_table_expiration_ms", "3600000"),
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "effective_labels.%", "2"),
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "effective_labels.env", "foo"),
	resource.TestCheckResourceAttr("google_bigquery_dataset.test", "effective_labels.default_table_expiration_ms", "3600000"),
	),
	},
	},
	})
	}

[wj-chen]

The v5.0.0 provider-level argument add_terraform_attribution_label was added to that test config in GoogleCloudPlatform/magic-modules@0b62ec9#diff-57b4fef051ae11c7000919221447c3ce38472429666af9e5d925a6df266ed075. Most tests that use that config are running with v5.0.0+ except this specific test that requires an older version. This test already existed when the attribute was added but appeared to not have run as part of GoogleCloudPlatform/magic-modules#11439.

@SirGitsalot and @c2thorn could you comment on add_terraform_attribution_label and fix this test?

[SirGitsalot]

GoogleCloudPlatform/magic-modules#12146

[wj-chen]

Thanks @SirGitsalot for the fix. I don't have access to the test run results but after the fix this should be good to close now?

[SarahFrench]

This test passed the last two nights; closing issue

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.