Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Confidential Computing examples to google_compute_instance and google_compute_instance_template resources #11518

Conversation

arthurlapertosa
Copy link
Contributor

Add Confidential Computing examples to google_compute_instance and google_compute_instance_template resources

In this PR, I directly added the examples to the html file, because I couldn't find a correct .yaml file that auto generates the htmls. Also, I used as reference these 3 PRs, which directly updates the same html files: #5279, #4973, #9131.

Release Note Template for Downstream PRs (will be copied)


@arthurlapertosa arthurlapertosa marked this pull request as ready for review August 22, 2024 00:22
@github-actions github-actions bot requested a review from melinath August 22, 2024 00:23
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@melinath
Copy link
Member

/gcbrun

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable - could you confirm that you're able to apply these configs? (with reasonable light modification as needed)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 92 insertions(+))
google-beta provider: Diff ( 2 files changed, 92 insertions(+))

@arthurlapertosa
Copy link
Contributor Author

This seems reasonable - could you confirm that you're able to apply these configs? (with reasonable light modification as needed)

Hey @melinath! Thanks for the review! By confirm that I'm able to apply these configs you mean running terraform apply and just sending a screenshot here or do you prefer that I send the whole output?

@github-actions github-actions bot requested a review from melinath August 22, 2024 18:14
@melinath
Copy link
Member

Hey @melinath! Thanks for the review! By confirm that I'm able to apply these configs you mean running terraform apply and just sending a screenshot here or do you prefer that I send the whole output?

I just mean say that you did it and I'll trust you 😂 I just want to make sure we've done due diligence that the examples work before publishing them

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing from queue pending response

@arthurlapertosa
Copy link
Contributor Author

Hey @melinath! Thanks for the review! By confirm that I'm able to apply these configs you mean running terraform apply and just sending a screenshot here or do you prefer that I send the whole output?

I just mean say that you did it and I'll trust you 😂 I just want to make sure we've done due diligence that the examples work before publishing them

Oh, got it!! They do work, I've tested and re-tested them!

@github-actions github-actions bot requested a review from melinath August 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants