-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Confidential Computing examples to google_compute_instance and google_compute_instance_template resources #11518
Add Confidential Computing examples to google_compute_instance and google_compute_instance_template resources #11518
Conversation
…ogle_compute_instance_template resources
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable - could you confirm that you're able to apply these configs? (with reasonable light modification as needed)
Hey @melinath! Thanks for the review! By confirm that I'm able to apply these configs you mean running |
I just mean say that you did it and I'll trust you 😂 I just want to make sure we've done due diligence that the examples work before publishing them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing from queue pending response
Oh, got it!! They do work, I've tested and re-tested them! |
Add Confidential Computing examples to
google_compute_instance
andgoogle_compute_instance_template
resourcesIn this PR, I directly added the examples to the html file, because I couldn't find a correct
.yaml
file that auto generates the htmls. Also, I used as reference these 3 PRs, which directly updates the same html files: #5279, #4973, #9131.Release Note Template for Downstream PRs (will be copied)