-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align manually generated documentation with #5192 #5279
Align manually generated documentation with #5192 #5279
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209156 |
This commit add internal links for nested types to manually generated pages, similar to GoogleCloudPlatform#5192.
Is thee interest in this? If so, I can fix the conflict. |
@juliocc yes, I'm working on reviewing it, it's just a very long and tedious process for this kind of PR. If you could fix the conflict that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this took a while to go through and verify the links. In the future, please split changes like this into multiple PRs, ideally grouped in some logical way, like changes to similar resources.
I've marked the links that seem to have issues. Thanks for contributing!
mmv1/third_party/terraform/website/docs/d/cloudfunctions_function.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/d/compute_instance_template.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/dataproc_job.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/dataproc_job.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/dataproc_job.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/dataproc_job.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/dataproc_job.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/storage_transfer_job.html.markdown
Outdated
Show resolved
Hide resolved
Apologies for XL PR. Wasn't sure what was better (single XL or multiple smaller). I'll rebase and fix the comments during the day. |
54c42e4
to
9336cec
Compare
9336cec
to
44b946d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210853 |
Tests failed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic Please fix these to complete your PR |
This PR adds internal links for nested types to manually generated pages, similar to #5192.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)