Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit that ephemeral IP is a public IP. #4973

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

diekmann
Copy link
Contributor

Attaching a VM with a public IP to the Internet can pose a security
risk. A public IP should only be assigned if this is desired. Many
things work without public IPs (for example, via the Identity-Aware
Proxy). This tiny addition to the example config makes it more obvious
that the innocent-looking empty config block gives us a public IP here.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Attaching a VM with a public IP to the Internet can pose a security
risk. A public IP should only be assigned if this is desired. Many
things work without public IPs (for example, via the Identity-Aware
Proxy). This tiny addition to the example config makes it more obvious
that the innocent-looking empty config block gives us a public IP here.
@google-cla google-cla bot added the cla: yes label Jul 16, 2021
@diekmann
Copy link
Contributor Author

Is it okay to send such tiny doc changes without running make test and make lint?

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@ScottSuarez
Copy link
Contributor

ya ! that's no problem ! Sorry for the delay on this guy @diekmann , thanks for the work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants