Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare removal of guest_accelerator ConfigModeAttr #11425

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 12, 2024

part of hashicorp/terraform-provider-google#12824

guest_accelerator's ConfigModeAttr can be directly removed in 6.0 because:

  1. existing logic to make guest_accelerator.count = 0 count as an empty entry, therefore an alternative way to send an empty list
  2. The field is ForceNew, meaning we don't need update functionality

I've manually tested that there is no difference between count = 0 and guest_accelerator = [] for google_container_cluster, google_container_node_pool, and google_compute_instance, and have added tests for them as well.

The child fields guest_accelerator.gpu_driver_installation_config and guest_accelerator.gpu_sharing_config have been added AFTER the 0.11->0.12 upgrade and look to have just copied the ConfigModeAttr attribute mistakenly: https://github.com/GoogleCloudPlatform/magic-modules/pull/8348/files#diff-058ffca5a3cb3663c791422e055902e433e8f27f44fd144c667cfe5ed95556eeR117 and https://github.com/GoogleCloudPlatform/magic-modules/pull/6628/files#diff-542bf08ccbb9e20a2abbf127fde6d38f61c83124b05370a5e53d3e4caa3512f4R110
In the rare chance a user has somehow utilized the empty block configuration [] for these, just removing the fields entirely will not produce a diff due to O+C.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 67 insertions(+))
google-beta provider: Diff ( 3 files changed, 67 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1179
Passed tests: 1095
Skipped tests: 82
Affected tests: 2

Click here to see the affected service packages
  • container
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstance_guestAcceleratorSkip
  • TestAccContainerNodePool_012_ConfigModeAttr

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_guestAcceleratorSkip[Debug log]
TestAccContainerNodePool_012_ConfigModeAttr[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@c2thorn c2thorn requested a review from rileykarson August 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants