Prepare removal of guest_accelerator ConfigModeAttr #19104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #12824
guest_accelerator
's ConfigModeAttr can be directly removed in 6.0 because:guest_accelerator.count = 0
count as an empty entry, therefore an alternative way to send an empty listForceNew
, meaning we don't need update functionalityI've manually tested that there is no difference between
count = 0
andguest_accelerator = []
forgoogle_container_cluster
,google_container_node_pool
, andgoogle_compute_instance
, and have added tests for them as well.The child fields
guest_accelerator.gpu_driver_installation_config
andguest_accelerator.gpu_sharing_config
have been added AFTER the 0.11->0.12 upgrade and look to have just copied the ConfigModeAttr attribute mistakenly: https://github.com/GoogleCloudPlatform/magic-modules/pull/8348/files#diff-058ffca5a3cb3663c791422e055902e433e8f27f44fd144c667cfe5ed95556eeR117 and https://github.com/GoogleCloudPlatform/magic-modules/pull/6628/files#diff-542bf08ccbb9e20a2abbf127fde6d38f61c83124b05370a5e53d3e4caa3512f4R110In the rare chance a user has somehow utilized the empty block configuration
[]
for these, just removing the fields entirely will not produce a diff due to O+C.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11425