Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare removal of guest_accelerator ConfigModeAttr #7949

Conversation

modular-magician
Copy link
Collaborator

part of hashicorp/terraform-provider-google#12824

guest_accelerator's ConfigModeAttr can be directly removed in 6.0 because:

  1. existing logic to make guest_accelerator.count = 0 count as an empty entry, therefore an alternative way to send an empty list
  2. The field is ForceNew, meaning we don't need update functionality

I've manually tested that there is no difference between count = 0 and guest_accelerator = [] for google_container_cluster, google_container_node_pool, and google_compute_instance, and have added tests for them as well.

The child fields guest_accelerator.gpu_driver_installation_config and guest_accelerator.gpu_sharing_config have been added AFTER the 0.11->0.12 upgrade and look to have just copied the ConfigModeAttr attribute mistakenly: https://github.com/GoogleCloudPlatform/magic-modules/pull/8348/files#diff-058ffca5a3cb3663c791422e055902e433e8f27f44fd144c667cfe5ed95556eeR117 and https://github.com/GoogleCloudPlatform/magic-modules/pull/6628/files#diff-542bf08ccbb9e20a2abbf127fde6d38f61c83124b05370a5e53d3e4caa3512f4R110
In the rare chance a user has somehow utilized the empty block configuration [] for these, just removing the fields entirely will not produce a diff due to O+C.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11425

[upstream:9cf5fdae724cb640e0acea885e4fa468fd494f7e]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 7c75e77 into hashicorp:main Aug 12, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-9cf5fdae724cb640e0acea885e4fa468fd494f7e branch November 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant